kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[APM][Services] Add links to log charts for quick access to Logs Explorer in service overview

Open iblancof opened this issue 1 year ago • 7 comments

Describe the feature:

We want to add links to the Log Rate and Log Error % charts. Each link should redirect to the Logs Explorer, filtered by log.level for either info or error, depending on the chart.

Link copy: Explore Logs

Screenshot 2024-08-14 at 15 55 56

iblancof avatar Aug 14 '24 15:08 iblancof

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine avatar Aug 14 '24 15:08 elasticmachine

Do we want to open the links in a new tab or the same?

kpatticha avatar Aug 26 '24 13:08 kpatticha

Do we want to open the links in a new tab or the same?

We (almost) always want to open in the same tab if we're staying in Kibana.

smith avatar Aug 26 '24 20:08 smith

I've noticed that links when using Lens charts open in a new tab

https://github.com/user-attachments/assets/8f5f8810-efae-48e4-822c-d14526198bbc

kpatticha avatar Aug 27 '24 07:08 kpatticha

I believe it makes sense to filter out also the service name since we're in the service overview page.

wdyt @roshan-elastic @iblancof ?

Without service.name filter

https://github.com/user-attachments/assets/7c098797-eedf-4ecb-a41a-6274f905e8e6

With service.name filter

https://github.com/user-attachments/assets/ec860bfc-362e-43db-9ced-604083d9e41a

kpatticha avatar Aug 28 '24 09:08 kpatticha

I believe it makes sense to filter out also the service name since we're in the service overview page.

wdyt @roshan-elastic @iblancof ?

I think that makes total sense, thanks for pointing it out @kpatticha! I had assumed we would filter by service and forgot to include it in the description.

iblancof avatar Aug 28 '24 09:08 iblancof

I believe it makes sense to filter out also the service name since we're in the service overview page.

Hey @kpatticha - for filtering out the service.name - won't that show all logs in the log-*?

I would have thought we'd have to filter for the service.name to show the metrics for this service?

I'm probably missing something.

roshan-elastic avatar Aug 28 '24 13:08 roshan-elastic

@roshan-elastic check the above recording With service.name filter

As user, since I'm in a specific service view I would expect when clicking "Explore logs" so show me ALL logs for this service in the logs explorer. Does this make sense to you?

kpatticha avatar Aug 28 '24 15:08 kpatticha

ah sorry, @iblancof pointed a mistake from my side. not filter out but filter by service.name. English is hard :smile

kpatticha avatar Aug 28 '24 15:08 kpatticha

Sorry @kpatticha I thought I'd replied to this but I hadn't.

Just confirming behaviour - is this what you were thinking?

1. Click on 'open logs' for log rate

  • Opens Logs Explorer filtered by service.name : SERVICE NAME using All Logs Data View

Image

2. Click on 'open logs' for log error rate

  • Opens Logs Explorer filtered by service.name : SERVICE NAME AND (log.level : "ERROR" OR log.level : "error" OR error.log.level : "error" using All Logs Data View

Image

What's error.log.level?

The error.log.level is something I thought we already had in the original formulae - if this is scope creep, we can always fix this in a new ticket (it basically catches APM error logs as well as those via log.level) - I know there a multiple places we would need to update the error log rate calculation to cater for this:

Image

roshan-elastic avatar Aug 29 '24 14:08 roshan-elastic