kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Global Search, Saved Objects Management] Use new parse option to specify recognized fields

Open tsullivan opened this issue 1 year ago • 3 comments

ParseOptions['recognizedFields'] is a new field of ParseOptions which controls how EuiSearchBar text is parsed into a Query object. This PR uses the new option to get better accuracy in how search terms are parsed when they include a : character.

Summary

Closes https://github.com/elastic/kibana/issues/184496 Depends on https://github.com/elastic/eui/pull/7960

GLOBAL SEARCH: BEFORE akshfgkalsfh-before

GLOBAL SEARCH: AFTER akshfgkalsfh-after

SAVED OBJECTS MANAGEMENT: BEFORE okjoyofjiuh-before

SAVED OBJECTS MANAGEMENT: AFTER okjoyofjiuh-after

SAVED OBJECTS FINDER: BEFORE lfdgnhklfd-before

SAVED OBJECTS FINDER: AFTER lfdgnhklfd-after

Checklist

  • [x] Ensure that filtering using type: and tags: still works

tsullivan avatar Aug 13 '24 21:08 tsullivan

/ci

tsullivan avatar Aug 27 '24 21:08 tsullivan

/ci

tsullivan avatar Aug 30 '24 19:08 tsullivan

/ci

tsullivan avatar Sep 05 '24 21:09 tsullivan

Pinging @elastic/appex-sharedux (Team:SharedUX)

elasticmachine avatar Sep 06 '24 17:09 elasticmachine

@jughosta

For the following use case it works great on Discover page but not on Saved Objects page. Is it expected?

Yes, this is expected because Elasticsearch seems to be using the default analyzer that breaks down the input into individual terms and then searches for documents that contain any of those terms.

See: https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-standard-analyzer.html

tsullivan avatar Sep 17 '24 23:09 tsullivan

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts / alerting api integration security and spaces enabled Alerts - Group 1 alerts backfill rule runs ad hoc backfill task should run all execution sets of a scheduled backfill and correctly generate alerts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsFinder 5.2KB 5.2KB +41.0B
savedObjectsManagement 84.5KB 84.5KB +41.0B
total +82.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 29.5KB 29.5KB -44.0B

History

  • :broken_heart: Build #234456 failed 482267ec3f117923a14e9ccdeb520f98ea4db27c
  • :green_heart: Build #233305 succeeded 7c851050cc1729cdcc96f655b4a72bf6949c2f60
  • :yellow_heart: Build #233262 was flaky fbcf86f5015c5b94415b18cf99ad20915dc0cf73
  • :green_heart: Build #232561 succeeded fbc5028e2c94a6d87d2aa919ab1e255c68b9fe4c
  • :broken_heart: Build #232329 failed 4461eb8ee823aa5286dabc82165c8273fbb8ecba

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Sep 18 '24 00:09 kibana-ci

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine avatar Sep 19 '24 16:09 kibanamachine