kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Add local EBT shipper

Open afharo opened this issue 1 year ago • 5 comments

Summary

This PR adds an example plugin that registers an EBT shipper that writes all the events to the local ES.

It's intended for development purposes. With this plugin devs can look realtime at their local discover all the events their local Kibana is generating.

Just add the dataviews ebt-kibana-server/ebt-kibana-browser to start exploring.

For maintainers

afharo avatar Jul 31 '24 19:07 afharo

Pinging @elastic/kibana-core (Team:Core)

elasticmachine avatar Jul 31 '24 19:07 elasticmachine

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • :green_heart: Build #225207 succeeded 11547af617fad02eff4929852d2fc5a943271ab4
  • :green_heart: Build #225170 succeeded 4b6ae7565d157c0d57dcccffee8b6efc00985570

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @afharo

kibana-ci avatar Aug 01 '24 01:08 kibana-ci

@TinaHeiligers thanks for the reviews! I revisited the comments inside the required-but-left-empty methods to be less "I don't care" and provide better reasoning for not implementing anything inside those methods. Please, let me know what you think.

LGTM

TinaHeiligers avatar Aug 01 '24 16:08 TinaHeiligers

This was in my notif list, so I was just passing by, but there's no update in one month so I will ask: should that be merged?

pgayvallet avatar Aug 30 '24 16:08 pgayvallet

This was in my notif list, so I was just passing by, but there's no update in one month so I will ask: should that be merged?

IIRC, I didn't merge it because we wanted to discuss further if we wanted this to be either a disabled-by-default plugin (instead of an example plugin) or a disabled-by-default feature inside the telemetry plugin. This way it can be reused in more scenarios (yarn start --serverless=es --run-examples doesn't run the examples, so the local EBT client cannot work when developing for serverless).

Happy to continue the discussion and adapt the PR.

afharo avatar Aug 30 '24 16:08 afharo

I've recently seen a few "complains" about EBT not being testable locally. So I decided to push this PR forward.

afharo avatar Jan 14 '25 23:01 afharo

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
telemetry 41 44 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
telemetry 4.0KB 4.8KB +828.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
telemetry 22.5KB 22.6KB +107.0B
Unknown metric groups

API count

id before after diff
telemetry 45 46 +1

async chunk count

id before after diff
telemetry 2 3 +1

History

  • :broken_heart: Build #267216 failed 2bdcb7423c74456c34b94aea5effa8aa3265e1bb
  • :broken_heart: Build #267214 failed 7aaabd3a66976f5b91c06b8a843297d648cffcf7
  • :broken_heart: Build #267209 failed 1a4f689319bdb0dc8f7de61660cf89215a7ec088
  • :broken_heart: Build #267182 failed 93e28d26a52a73622e9a4e05beda44a60a77cf17

cc @afharo

elasticmachine avatar Jan 15 '25 12:01 elasticmachine