kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[SecuritySolution] Re-score entities after an asset criticality bulk upload

Open machadoum opened this issue 1 year ago • 5 comments

Summary

  • Create new API /internal/risk_score/engine/schedule_now
  • Fix storybook, it was broken due to some mock changes
  • Update status API to return task status
  • Add schedule risk engine panel to bulk asset criticality final step

Screenshot 2024-08-27 at 10 06 25

How to test it?

  • Enable asset criticality in stack management / Advanced settings
  • Enable the risk engine
  • Open the asset criticality page inside the Manage section
  • Upload a valid file
  • Verify that the new panel is present and that you can schedule the risk engine run by pressing the button

Checklist

Delete any items that are not applicable to this PR.

machadoum avatar Jul 04 '24 13:07 machadoum

/ci

machadoum avatar Aug 08 '24 10:08 machadoum

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine avatar Aug 27 '24 08:08 elasticmachine

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

elasticmachine avatar Aug 27 '24 08:08 elasticmachine

tested locally it works well 👍

@natasha-moore-elastic would you be able to review the copy for this when you get chance? It is just the blue modal in the screenshot above.

hop-dev avatar Aug 27 '24 09:08 hop-dev

@elasticmachine merge upstream

hop-dev avatar Aug 29 '24 12:08 hop-dev

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / Configure updates field options correctly when not required

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5660 5662 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +4.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.4KB 86.5KB +161.0B

History

  • :broken_heart: Build #231975 failed 19cc4f1a429ca310d0004a33a1c2ddcaa8feb759
  • :broken_heart: Build #230793 failed 4757a24b478dc57691d6cad0043ab2761ea73244
  • :broken_heart: Build #230771 failed ab9e29d09e7ce96360133b62a64c99f7fc9c3c74
  • :broken_heart: Build #230429 failed 36b3c48c0da71e8a8fecf3de5b1c613db736db1e
  • :yellow_heart: Build #230106 was flaky f43314639548ff65376a6f8e9fc44c39b162f7f3

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @machadoum

kibana-ci avatar Sep 05 '24 10:09 kibana-ci