[Lens] Chart switch redesign
Summary
- The main change is chart switch redesign:
- Toolbar changes for most of the visualization (refer to design files)
Subtasks
- reorders the elements in the charts switch
- redesigns chart switch visually
- adds deprecated group (metric)
- changes the add subtype layer menu
- adds description to chart switch
- subselect for bar/gauge visualizations
- adds border to workspace panel
- changes
boxesHorizontalicon toboxesVertical
Resolves https://github.com/elastic/kibana/issues/179260 also fixes https://github.com/elastic/kibana/issues/182677 switching between chart types
Pinging @elastic/kibana-visualizations (Team:Visualizations)
Flaky Test Runner Stats
🎉 All tests passed! - kibana-flaky-test-suite-runner#6821
[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group2.ts: 25/25 tests passed. [✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group3.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group1/config.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group2/config.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group3/config.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group4/config.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group5/config.ts: 25/25 tests passed. [✅] x-pack/test/functional/apps/lens/group6/config.ts: 25/25 tests passed.
Apologies for not noticing this earlier, @markov00 made me how the description of charts might need a little review, I'll try write a few considerations here by the end of the day
Here I am with a few suggestions, please consider that as options, everything is up to discuss:
Bar Current: Compare categories or groups of data via bars. Proposal: Compare categories or groups of data with bars.
Line Current: Reveal variations in data over time or categorically. Proposal: Reveal variations in data over time.
Area Compare distributions of cumulative data trends. nothing to change
Metric Present individual key metrics or KPIs. nothing to change
Table Organize data in structured rows and columns. nothing to change
Pie Current: Display proportions of a whole in a circular format. Proposal: Display parts of a whole in a circular format.
Gauge Show progress to a goal in linear or arced style. nothing to change
Heat map Show density or distribution across two dimensions. nothing to change
Waffle Represent data proportions via a grid of colored cells. nothing to change
Region map Show geographic data using colored regions. nothing to change
Treemap Current: Use nested rectangles to show proportionality. Proposal: Use nested rectangles to show proportions and hierarchy.
Tag cloud Current: Visualize text data frequency or importance. nothing to change
Mosaic Current: Show proportions of categorical data via rectangles. Proposal: Show proportions of categorical data with rectangles.
Legacy Metric Present individual key metrics or KPIs. nothing to change
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 725e2663610b4d986fc417c30c92769f05b12145
- Storybooks Preview
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
apm |
1868 | 1872 | +4 |
eventAnnotationListing |
569 | 573 | +4 |
expressionGauge |
103 | 107 | +4 |
expressionHeatmap |
174 | 178 | +4 |
expressionPartitionVis |
189 | 193 | +4 |
expressionTagcloud |
163 | 167 | +4 |
expressionXY |
250 | 254 | +4 |
infra |
1504 | 1508 | +4 |
lens |
1439 | 1447 | +8 |
maps |
1232 | 1236 | +4 |
observability |
1045 | 1049 | +4 |
| total | +48 |
Public APIs missing comments
Total count of every public API that lacks a comment. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats commentsfor more detailed information.
| id | before | after | diff |
|---|---|---|---|
@kbn/chart-icons |
84 | 90 | +6 |
@kbn/test-eui-helpers |
18 | 19 | +1 |
lens |
586 | 589 | +3 |
| total | +10 |
Any counts in public APIs
Total count of every any typed public API. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats anyfor more detailed information.
| id | before | after | diff |
|---|---|---|---|
@kbn/test-eui-helpers |
0 | 1 | +1 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
apm |
3.5MB | 3.5MB | +104.0B |
expressionGauge |
22.6KB | 21.9KB | -642.0B |
expressionHeatmap |
26.6KB | 26.7KB | +102.0B |
expressionPartitionVis |
36.5KB | 35.9KB | -612.0B |
expressionTagcloud |
18.8KB | 19.0KB | +132.0B |
expressionXY |
129.3KB | 127.7KB | -1.6KB |
infra |
1.5MB | 1.5MB | +105.0B |
lens |
1.5MB | 1.5MB | +26.8KB |
maps |
3.0MB | 3.0MB | +164.0B |
observability |
461.8KB | 461.7KB | -103.0B |
| total | +24.4KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
eventAnnotationListing |
11.1KB | 11.0KB | -103.0B |
lens |
51.7KB | 51.6KB | -88.0B |
| total | -191.0B |
Unknown metric groups
API count
| id | before | after | diff |
|---|---|---|---|
@kbn/chart-icons |
84 | 90 | +6 |
@kbn/test-eui-helpers |
36 | 37 | +1 |
lens |
688 | 691 | +3 |
| total | +10 |
History
- :yellow_heart: Build #231855 was flaky 529b174f57569ac76c7b8755531d5efdb81e0094
- :broken_heart: Build #231801 failed 14b1f7a159f18fd3b32444da0250d08253a48b83
- :broken_heart: Build #231691 failed 2b8f60da0f625059e22424529448d5b7fcf5177b
- :yellow_heart: Build #231594 was flaky ff8642f807705eddf8f2d7a0484bc0e90bbe6d66
- :green_heart: Build #231316 succeeded 5435f503088b310fa587ff32e8c6d86f2c3a7cfb
- :broken_heart: Build #231312 failed 14e0c1fd15c1b388f2c0440603ae736c4b757d28
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream