kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[APM Plugin - Browser] Migrate authc.getCurrentUser usage to coreStart.security

Open tsullivan opened this issue 1 year ago • 4 comments

Part of https://github.com/elastic/kibana/issues/186574

Summary

This PR migrates the method to access an APM Plugin view model field, which consumes authc.getCurrentUser, to use coreStart.security.

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.

Checklist

Delete any items that are not applicable to this PR.

tsullivan avatar Jun 28 '24 21:06 tsullivan

/ci

tsullivan avatar Jun 28 '24 21:06 tsullivan

Pinging @elastic/apm-ui (Team:APM)

elasticmachine avatar Jun 28 '24 23:06 elasticmachine

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine avatar Jun 28 '24 23:06 elasticmachine

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 35.1KB 35.2KB +27.0B
Unknown metric groups

References to deprecated APIs

id before after diff
apm 35 33 -2

History

  • :green_heart: Build #218574 succeeded dfb3e152ab97bbd3cff5c4257ce02954cbab73a8

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Jul 01 '24 23:07 kibana-ci