kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Serverless Search Plugin] Migrate authc.getCurrentUser usage to coreStart.security

Open tsullivan opened this issue 1 year ago • 2 comments

Part of https://github.com/elastic/kibana/issues/186574

Summary

This PR migrates the method to access a Serverless Search view model field, which consumes authc.getCurrentUser, to use coreStart.security.

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0.

Checklist

Delete any items that are not applicable to this PR.

tsullivan avatar Jun 28 '24 20:06 tsullivan

/ci

tsullivan avatar Jun 28 '24 21:06 tsullivan

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessSearch 20.6KB 20.6KB -6.0B
Unknown metric groups

References to deprecated APIs

id before after diff
serverlessSearch 3 2 -1

History

  • :green_heart: Build #218577 succeeded 19d0d33fc9c3187d79a696a914ec5bff9009d708

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Jul 01 '24 17:07 kibana-ci

:green_heart: Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessSearch 20.6KB 20.6KB -6.0B
Unknown metric groups

References to deprecated APIs

id before after diff
serverlessSearch 3 2 -1

elasticmachine avatar Jul 02 '24 16:07 elasticmachine

For your reference we migrated (almost) all the other getCurrentUser calls here: https://github.com/elastic/kibana/pull/184762

sphilipse avatar Jul 03 '24 09:07 sphilipse