kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[EDR Workflows][Process descendants filter] Display process descendant filtering on event filter cards

Open gergoabraham opened this issue 1 year ago • 2 comments

Summary

The modifications indicate to the users if an Event Filter filters process descendants, displayed on Event Filters page and on Policy page's Event Filters tab (todo).

Checklist

Delete any items that are not applicable to this PR.

gergoabraham avatar Jun 28 '24 17:06 gergoabraham

@ferullo @caitlinbetz at the moment indicating Process Descendant filtering looks like below. can we live with this? :)

image image

gergoabraham avatar Jun 28 '24 17:06 gergoabraham

@ferullo @caitlinbetz at the moment indicating Process Descendant filtering looks like below. can we live with this? :)

Yes. It looks great. 💯

ferullo avatar Jun 28 '24 18:06 ferullo

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

elasticmachine avatar Jul 01 '24 20:07 elasticmachine

@elasticmachine merge upstream

gergoabraham avatar Jul 02 '24 07:07 gergoabraham

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #46 / @skipInServerless endpoint @ess @serverless For each artifact list under management When on the Event Filters entries list should be able to add a new Event Filters entry

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @gergoabraham

note: the failing test looked suspicious, because it's related to event filters, and even worse, the first occurrence was during kibana-on-merge for the previous process descendant PR:

  • test fail issue: https://github.com/elastic/kibana/issues/187314
  • previous PR that triggered it on-merge: https://github.com/elastic/kibana/pull/187141

but fortunately, it looks like coincidence 😌 locally the test has passed, and the similar errors happened previously:

  • https://github.com/elastic/kibana/issues/186004
  • https://github.com/elastic/kibana/issues/186004

gergoabraham avatar Jul 02 '24 09:07 gergoabraham

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / ColumnsPopover renders correctly a list of selected columns

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5583 5585 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.5MB 15.6MB +5.3KB

History

  • :yellow_heart: Build #219021 was flaky bab59f1a78924b9efe080e91bf9947b77da1ec1f
  • :broken_heart: Build #218994 failed d556750cb9922e9d20897bd9de51b68cd8749b16

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @gergoabraham

kibana-ci avatar Jul 02 '24 11:07 kibana-ci