kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Search] [Playground] Re-enable Full width view + fix scrollbar issue

Open joemcelroy opened this issue 1 year ago • 1 comments
trafficstars

Summary

Fixes two issues:

  • the view should be full width, so removing restrictWidth option
  • in serverless, the content view was scrollable, even when the vertical content did not exceed the screen.

On scrollbar fix:

  • grow adds a min-block-size: max($minHeight, 100vh). minHeight is by default 460px. 100vh which doesn't take into account the header, adding a scrollbar with extra size from header. A fix ive seen other solutions do is either specify 0 in minHeight (which omits the block-size css style which is a side-effect) or switch off grow (min-block-size:$minHeight). I've opted for grow=false as our children components manage the height.

Without fix image

With fix image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

joemcelroy avatar May 11 '24 21:05 joemcelroy

@elasticmachine merge upstream

joemcelroy avatar May 13 '24 07:05 joemcelroy

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • :green_heart: Build #209358 succeeded f8ab77f39e7f793676026f1f8ce9c9a025a08817
  • :green_heart: Build #209355 succeeded 48c5cfeb7921ab584d34ebb31be3c6e17ed91c95

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar May 13 '24 10:05 kibana-ci

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine avatar May 13 '24 10:05 kibanamachine