kibana
kibana copied to clipboard
[Search] [Playground] Re-enable Full width view + fix scrollbar issue
trafficstars
Summary
Fixes two issues:
- the view should be full width, so removing restrictWidth option
- in serverless, the content view was scrollable, even when the vertical content did not exceed the screen.
On scrollbar fix:
- grow adds a
min-block-size: max($minHeight, 100vh). minHeight is by default 460px. 100vh which doesn't take into account the header, adding a scrollbar with extra size from header. A fix ive seen other solutions do is either specify 0 in minHeight (which omits the block-size css style which is a side-effect) or switch off grow (min-block-size:$minHeight). I've opted for grow=false as our children components manage the height.
Without fix
With fix
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [x] This was checked for cross-browser compatibility
- [x] Tested in both serverless and stateful
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
@elasticmachine merge upstream
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: 1ca624fb315af4ddb4eb5d10f6608ba4cc4af7fb
Failed CI Steps
Metrics [docs]
✅ unchanged
History
- :green_heart: Build #209358 succeeded f8ab77f39e7f793676026f1f8ce9c9a025a08817
- :green_heart: Build #209355 succeeded 48c5cfeb7921ab584d34ebb31be3c6e17ed91c95
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.14 |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation