kibana
kibana copied to clipboard
elastic
[ML] Single Metric Viewer embeddable in dashboards: move all config to flyout
Summary
Part of https://github.com/elastic/kibana/issues/182042 This PR also fixes the issue in the swimlane embeddable that fails to close the flyout if navigating into the main dashboards page.
Related meta issue: https://github.com/elastic/kibana/issues/181272
Item: https://github.com/elastic/kibana/issues/181272
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Testing this I also found an issue when changing the selected job (also happens on main). I think this occurs when switching from a job with 1 detector to one with multiple detectors and selecting the detector at an index which doesn't exist in the first job. Here I select a job with 2 detectors and pick the second detector.
Looks like buildConfigFromDetector in chart_config_builder.ts is called several times, and at one point is passed the config for the previously selected job but the detector index from the new selection:
https://github.com/elastic/kibana/assets/7405507/bad74cb0-bb47-43bc-b7fa-cb495aa149aa
Created a separate PR for the fix for the issue you found, @peteharverson so we can backport to 8.14. 👍
This is ready for another look when you get a chance cc @darnautov, @peteharverson
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: 7603fd4b17fff9107d2d8a2ceb04547a7bcd46ac
Failed CI Steps
Test Failures
- [job] [logs] FTR Configs #44 / Lists plugin Lists API "before all" hook for "should return a 400 if an endpoint exception item with a list-based entry is provided"
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
ml |
2013 | 2012 | -1 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
ml |
4.2MB | 4.2MB | +519.0B |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
ml |
77.0KB | 77.0KB | -2.0B |
History
- :yellow_heart: Build #209322 was flaky 15802230a7251105a4fdfe845e1e91caf9c778b0
- :broken_heart: Build #209303 failed aedae88d210a9522a57bbc6a42334b73577150a7
- :broken_heart: Build #209255 failed 8775a1a4d90946f96fc3e30ad9a9ce274172060f
- :broken_heart: Build #209065 failed 5dd476550c2fe02731034b2ca1d5d59c58863d2a
- :broken_heart: Build #209019 failed 7e3b004a5255f450ce23964cfa2235a68126dcf5
- :broken_heart: Build #208770 failed 18535176b1b7b4e1b98be9381de33fdee31779f7
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @alvarezmelissa87
