kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[ES|QL] Sorting accepts expressions

Open drewdaemon opened this issue 1 year ago • 4 comments

Summary

SORT accepts expressions as of https://github.com/elastic/elasticsearch/pull/107158.

This PR updates the validator and autocompletion engine to account for this improvement.

Checklist

  • [ ] Documentation was added — looks like docs haven't been added for this feature yet. I opened the discussion with ES team (ref)
  • [x] Unit or functional tests were updated or added to match the most common scenarios

drewdaemon avatar Apr 26 '24 20:04 drewdaemon

/ci

drewdaemon avatar Apr 26 '24 20:04 drewdaemon

/ci

drewdaemon avatar Apr 26 '24 20:04 drewdaemon

Pinging @elastic/kibana-esql (Team:ESQL)

elasticmachine avatar Apr 26 '24 22:04 elasticmachine

@elasticmachine merge upstream

drewdaemon avatar May 01 '24 15:05 drewdaemon

:green_heart: Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.1MB 3.1MB +98.0B

History

  • :yellow_heart: Build #206509 was flaky 487ec03cfca9a9311d9fa2abd2f4153e0f34690e
  • :green_heart: Build #206458 succeeded eb965c97a774fe4048d05666059a9873e3ce88a2

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar May 01 '24 17:05 kibana-ci

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine avatar May 01 '24 17:05 kibanamachine