kibana
kibana copied to clipboard
[data visualizer] fix clicking field statistics 'Explore in maps' button does not take users to maps
Fixes https://github.com/elastic/kibana/issues/181900
PR resolves issue by
- strongly typing
triggerOptions
toVisualizeFieldContext
so future type changes toVisualizeFieldContext
will be picked up by this file - Add more protection to
visualizeGeoFieldAction.isCompatible
method to prevent executing invalid context.
Out of scope for PR - updating "field statistics" to not show "Explore in maps" when action compatibility check fails. visualizeGeoFieldAction.isCompatible
is async while getActions
is sync.
test
- install sample web logs
- Open discover
- Change data table view to field statistics by clicking "Field statistics" toggle.
- Click "Explore in maps" action button for field
geo.coordinates
. - Verify map is opened showing geo.coordinates
/ci
Pinging @elastic/kibana-presentation (Team:Presentation)
Tested and LGTM 🎉 I'll handle the visualizeGeoFieldAction.isCompatible
logic in this PR after this PR is merged.
@elasticmachine merge upstream
:green_heart: Build Succeeded
- Buildkite Build
- Commit: ea640d06c9e4aa474fd097d6dcc10faba31f3c93
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
dataVisualizer |
659.5KB | 659.5KB | +4.0B |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
maps |
50.5KB | 50.5KB | +38.0B |
History
- :broken_heart: Build #206423 failed 7d8f9c89cd03a70b53dfbf7b15b6bbc3a757ad18
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
💚 All backports created successfully
Status | Branch | Result |
---|---|---|
✅ | 8.14 |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation