kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[data visualizer] fix clicking field statistics 'Explore in maps' button does not take users to maps

Open nreese opened this issue 9 months ago • 4 comments

Fixes https://github.com/elastic/kibana/issues/181900

PR resolves issue by

  1. strongly typing triggerOptions to VisualizeFieldContext so future type changes to VisualizeFieldContext will be picked up by this file
  2. Add more protection to visualizeGeoFieldAction.isCompatible method to prevent executing invalid context.

Out of scope for PR - updating "field statistics" to not show "Explore in maps" when action compatibility check fails. visualizeGeoFieldAction.isCompatible is async while getActions is sync.

test

  1. install sample web logs
  2. Open discover
  3. Change data table view to field statistics by clicking "Field statistics" toggle.
  4. Click "Explore in maps" action button for field geo.coordinates.
  5. Verify map is opened showing geo.coordinates

nreese avatar Apr 26 '24 17:04 nreese

/ci

nreese avatar Apr 26 '24 17:04 nreese

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine avatar Apr 26 '24 17:04 elasticmachine

Tested and LGTM 🎉 I'll handle the visualizeGeoFieldAction.isCompatible logic in this PR after this PR is merged.

qn895 avatar Apr 26 '24 18:04 qn895

@elasticmachine merge upstream

nreese avatar Apr 29 '24 13:04 nreese

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 659.5KB 659.5KB +4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 50.5KB 50.5KB +38.0B

History

  • :broken_heart: Build #206423 failed 7d8f9c89cd03a70b53dfbf7b15b6bbc3a757ad18

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Apr 29 '24 15:04 kibana-ci

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine avatar Apr 29 '24 20:04 kibanamachine