kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[ES|QL] highlighting is incorrect when the error comes from the server

Open drewdaemon opened this issue 1 year ago • 2 comments

Kibana version: 8.14

When a user submits a query and gets an error from Elasticsearch, we try to highlight the relevant bit. But, we often fail and the highlight shows up in seemingly-random places.

A couple of examples

from kibana_sample_data_logs | eval abs(@timestamp) | limit 10

Screenshot 2024-04-26 at 9 44 04 AM

from kibana_sample_data_logs | limit 23408239482038

Screenshot 2024-04-26 at 9 43 03 AM

drewdaemon avatar Apr 26 '24 17:04 drewdaemon

Pinging @elastic/kibana-esql (Team:ESQL)

elasticmachine avatar Apr 26 '24 17:04 elasticmachine

I was on the fence between impact:low and impact:medium. This bug doesn't prevent the user from seeing the message and figuring out what went wrong. But I could definitely see it being confusing...

drewdaemon avatar Apr 26 '24 17:04 drewdaemon

My guess here is that the error position is not being returned correctly from ES but we need to check. I havent encountered ever tbh so is def low

stratoula avatar Jun 03 '24 11:06 stratoula