kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[data.search] Fix unhandled promise rejections

Open lukasolson opened this issue 10 months ago • 3 comments

Summary

Resolves https://github.com/elastic/kibana/issues/168957.

It turns out the underlying issue was resolved in https://github.com/elastic/kibana/pull/170041 (unhandled errors when deleting not being handled). However this still left it up to consumers of pollSearch to be 100% sure they weren't leaking unhandled promise rejections. This adds code directly to pollSearch that will handle rejections if they aren't handled in the calling code. It also adds tests to consumers of pollSearch to make sure they don't barf in the case that the cancel function errors.

Checklist

lukasolson avatar Apr 25 '24 22:04 lukasolson

/ci

lukasolson avatar Apr 25 '24 22:04 lukasolson

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine avatar Apr 26 '24 17:04 elasticmachine

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / maps app maps loaded from sample data "before all" hook in "maps loaded from sample data"

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 417.5KB 417.6KB +98.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
data 52 54 +2

Total ESLint disabled count

id before after diff
data 54 56 +2

History

  • :green_heart: Build #206430 succeeded d723bd4ea87448b2802e33f7b6daef3c4bb62af0
  • :yellow_heart: Build #206172 was flaky f0c92529ae29cfbe7d48fd5b70c6ae0c808bc560

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @lukasolson

kibana-ci avatar Apr 29 '24 18:04 kibana-ci