kibana
kibana copied to clipboard
Published
20 hours ago •
elastic
elastic
move a bunch of code from container to controller
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 2617434de8904f2ad50b69c84ff0e8967f748694
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
dataViewFieldEditor |
175.3KB | 176.3KB | +994.0B |
History
- :green_heart: Build #209378 succeeded 23d3648ca3c705e909cb7c5bf9b3c6af92dc999c
- :green_heart: Build #208306 succeeded cd4eca6a49b132f6b14d7b88c79de68c1aebfbb9
- :green_heart: Build #207999 succeeded a386c56ef18d43462155944c63443a752c395491
- :green_heart: Build #207959 succeeded 8e144a8f78b1f8323c15e358e9ab80f4c035ba65
- :broken_heart: Build #207877 failed b5fa78b1a011c053fd003e3c4289c06e519c54f5
- :yellow_heart: Build #207045 was flaky e74c72faeeed79f5e874ee913baf0b8d04a3d180
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @mattkime
