kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Threat Hunting] Move the API tests to the `x-pack/test/security_solution_api_integration` folder

Open MadameSheema opened this issue 10 months ago • 5 comments

As part of this ticket we have to:

  • [ ] Move the tests inside the x-pack/test/security_solution_api_integration folder.
  • [ ] There is a specific folder per each one of the area teams to improve the visibility and ownesrhip of them.
  • [ ] Update the CODEOWNERS file to reflect the new changes
  • [ ] Add the @ess and @serverless labels to each corresponding test
  • [ ] Make sure that everything is properly integrated with buildkite and tests are executed as part of the CI process.

MadameSheema avatar Apr 25 '24 10:04 MadameSheema

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine avatar Apr 25 '24 10:04 elasticmachine

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine avatar Apr 25 '24 10:04 elasticmachine

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

elasticmachine avatar Apr 25 '24 10:04 elasticmachine

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

elasticmachine avatar Apr 25 '24 10:04 elasticmachine

To relocate:

  • x-pack/test/timeline
  • x-pack/test/security_solution_endpoint/
  • x-pack/test/security_solution_endpoint_api_int/

Should remove this file from .buildkite/ftr_configs.yml:

  • x-pack/test/api_integration/apis/security_solution/config.ts

angorayc avatar Apr 26 '24 17:04 angorayc

Hi @angorayc, I see a linked PR that has been merged and another as a "draft". Could you please mark the changes that have been completed in the description? Thanks!

semd avatar May 22 '24 10:05 semd

  • https://github.com/elastic/kibana/pull/181605 relocates:

x-pack/test/api_integration/apis to x-pack/test/security_solution_api_integration

  • [x] Move the tests inside the x-pack/test/security_solution_api_integration folder.
  • [x] There is a specific folder per each one of the area teams to improve the visibility and ownesrhip of them.
  • [x] Update the CODEOWNERS file to reflect the new changes
  • [x] Add the @ess and @serverless labels to each corresponding test
  • [x] Make sure that everything is properly integrated with buildkite and tests are executed as part of the CI process.

======

  • https://github.com/elastic/kibana/pull/183611 relocates:
  1. x-pack/test/security_solution_endpoint_api_int to pack/test/security_solution_api_integration/test_suites/security_solution_endpoint_api_int
  2. x-pack/test/security_solution_endpoint to pack/test/security_solution_api_integration/test_suites/security_solution_endpoint
  3. x-pack/test/timeline to pack/test/security_solution_api_integration/test_suites/investigation/timeline
  • [x] Move the tests inside the x-pack/test/security_solution_api_integration folder.
  • [x] There is a specific folder per each one of the area teams to improve the visibility and ownesrhip of them.
  • [x] Update the CODEOWNERS file to reflect the new changes
  • [x] Add the @ess and @serverless labels to each corresponding test
  • [x] Make sure that everything is properly integrated with buildkite and tests are executed as part of the CI process.

angorayc avatar May 22 '24 14:05 angorayc

@MadameSheema all the PRs for this issue have been merged, is it alright if I close this?

angorayc avatar Jun 04 '24 12:06 angorayc

Next step 1: https://github.com/elastic/kibana/issues/181684 I will add the scripts to x-pack/test/security_solution_api_integration/package.json for new test suits added in this issue.

Scripts should be added:

qa:serverless
qa:serverless:release

Next step 2: Once platform_engineer role is supported by the api tests, we should stop using admin role and use platform_engineer for api integration tests https://github.com/elastic/kibana/issues/184806 https://github.com/elastic/kibana/issues/184807

parent issue (please read this issue first before working on issues above): https://github.com/elastic/kibana/issues/184135

angorayc avatar Jun 05 '24 09:06 angorayc