kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[SLO Embeddable rebuild] move error budget embeddable to the new react registry

Open mgiota opened this issue 10 months ago • 7 comments

Fixes https://github.com/elastic/kibana/issues/179294

🍒 Summary

This PR converts the SLO Error budget burn down embeddable to the new React Embeddable framework. There are no UI changes to the current embeddable and the behavior should be the same. I have a video of how the embeddable should work.

https://github.com/elastic/kibana/assets/2852703/aaba8114-f74f-4dd7-8999-497bf9388562

✔️ Acceptance criteria

  • A new create_error_budget_action action is created, which adds the SLO Error budget burn down option in the Add panel section
  • The SLO Error budget burn down menu option is grouped under SLOs menu
  • Clicking on the SLO name should open a Flyout with the SLO details
  • Within the Flyout the Add to Dashboard option while hovering on the Error Budget burn down should not be visible
  • On the SLO Details page, the Add to Dashboard option while hovering on the Error Budget burn down should be visible
  • Kibana screenshot tool should report no timeout error.
  • Clicking on the Refresh button should reload the embeddable
  • No reaction to the kql bar, datepicker or controls (New tickets will cover these after the migration, https://github.com/elastic/kibana/issues/181426 & https://github.com/elastic/kibana/issues/181498)
Screenshot 2024-04-24 at 12 20 18

mgiota avatar Apr 24 '24 09:04 mgiota

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Apr 24 '24 09:04 apmmachine

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine avatar Apr 24 '24 10:04 elasticmachine

@elasticmachine merge upstream

mgiota avatar Apr 25 '24 21:04 mgiota

@elasticmachine merge upstream

mgiota avatar Apr 26 '24 07:04 mgiota

@elasticmachine merge upstream

mgiota avatar Apr 26 '24 08:04 mgiota

@ThomThomson Thanks for the feedback. I applied most of it, I just didn't know how to proceed with the defaultTitle suggestion.

mgiota avatar Apr 26 '24 10:04 mgiota

@elasticmachine merge upstream

mgiota avatar Apr 29 '24 08:04 mgiota

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
slo 726 735 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 722.7KB 720.3KB -2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
slo 22.1KB 22.3KB +184.0B
Unknown metric groups

async chunk count

id before after diff
slo 28 25 -3

History

  • :green_heart: Build #206357 succeeded d4a450beb06b0f965d38c1f0ffeafb1659b51890
  • :green_heart: Build #206312 succeeded 40f187e3645ce75f519546ebaea9d539d43ab2d8
  • :green_heart: Build #206254 succeeded c431d463b1d97c8b51940187454ec0a2162c898e
  • :green_heart: Build #206167 succeeded b319735c4f74d8dcfc6367470a218963def64101
  • :green_heart: Build #205596 succeeded d5fb1579cadaebf79e83276282eb0de70813f8f7
  • :broken_heart: Build #205572 failed 13570093eb49b38462a60c277fa5972ff70f6942

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @mgiota

kibana-ci avatar Apr 29 '24 09:04 kibana-ci