kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[SLO] APM latency SLI - add custom panel to alert details

Open dominiqueclarke opened this issue 11 months ago • 14 comments

Summary

Adds the APM latency, throughput, and error rate chart to the APM latency SLI's alert details page.

image

Testing

  1. Generate some APM data. The easiest way to do so is to via synthtrace, for example node scripts/synthtrace many_transactions.ts --live
  2. Navigate to the SLO page. Create an APM latency SLI with a threshold of 2500 ms.
  3. Wait for an alert to fire
  4. Navigate to the alert details page for the alert to view the charts.
  5. Navigate to the APM page for the service selected. Compare the charts to confirm the accuracy.
  6. Ideally, you'd repeat this test with many different configurations of the SLI, for example an SLI with a specific environment, transaction type, or transaction name, and compare the charts from the APM page for accuracy.

dominiqueclarke avatar Mar 20 '24 17:03 dominiqueclarke

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Mar 20 '24 17:03 apmmachine

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine avatar Mar 25 '24 16:03 elasticmachine

@dominiqueclarke I am trying to review this PR, can you please help me understand what is a custom panel and what is the best way to review the code? Is code review enough or do I need to check something locally?

maryam-saeidi avatar Mar 27 '24 09:03 maryam-saeidi

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine avatar Mar 27 '24 14:03 elasticmachine

@dominiqueclarke I am trying to review this PR, can you please help me understand what is a custom panel and what is the best way to review the code? Is code review enough or do I need to check something locally?

@maryam-saeidi I apologize. This PR was initially meant to be a small PR, which is why I opened it up to review, but after chatting with Panagiota I decided to make this PR larger. Because of that it's actually not ready for review. I'll convert it back to draft.

dominiqueclarke avatar Mar 27 '24 14:03 dominiqueclarke

/ci

dominiqueclarke avatar Mar 27 '24 22:03 dominiqueclarke

/ci

dominiqueclarke avatar May 06 '24 17:05 dominiqueclarke

/ci

dominiqueclarke avatar May 06 '24 17:05 dominiqueclarke

/ci

dominiqueclarke avatar May 06 '24 17:05 dominiqueclarke

/ci

dominiqueclarke avatar May 06 '24 19:05 dominiqueclarke

/ci

dominiqueclarke avatar May 07 '24 13:05 dominiqueclarke

/ci

dominiqueclarke avatar May 07 '24 16:05 dominiqueclarke

@dominiqueclarke I did a very quick pass and looks great! I will do a code review and test it locally. Just wanted to comment on the 8.14 tag. I guess we should change it to 8.15

mgiota avatar May 08 '24 20:05 mgiota

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1676 1734 +58
slo 747 750 +3
total +61

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +28.8KB
slo 765.8KB 767.8KB +2.0KB
total +30.8KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 34.6KB 35.8KB +1.1KB
Unknown metric groups

async chunk count

id before after diff
apm 32 36 +4

History

  • :green_heart: Build #209316 succeeded 2e68023fb6cae394168e84f63954a1c40cd6fe47
  • :broken_heart: Build #209283 failed ddf45fe181bde4ec6173c78f5096f109b9a3f547
  • :broken_heart: Build #209067 failed b559452a093a0842532f8136a088d195d1f48e81
  • :broken_heart: Build #209036 failed 12d807ba0352bcae6180ec37117f2d0840d4d62b

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar May 13 '24 14:05 kibana-ci