kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[Links] Migrate Links panel to the React embeddable framework

Open nickpeihl opened this issue 11 months ago • 7 comments

Fixes #174970

Summary

Migrates the legacy Links embeddable to the React embeddable framework.

Additionally, the new embeddable factory now resolves the dashboards info prior to rendering the Links component. Prior to this change, the DashboardLinkComponent would be responsible for asynchronously loading dashboards info and rendering a loading icon. This change reduces the complexity of the DashboardLinkComponent as the resolved state is now passed in as props.

nickpeihl avatar Mar 13 '24 18:03 nickpeihl

/ci

nickpeihl avatar Apr 23 '24 19:04 nickpeihl

/ci

nickpeihl avatar Apr 23 '24 19:04 nickpeihl

/ci

nickpeihl avatar Apr 26 '24 16:04 nickpeihl

/ci

nickpeihl avatar Apr 26 '24 16:04 nickpeihl

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine avatar Apr 26 '24 18:04 elasticmachine

/ci

nickpeihl avatar Apr 26 '24 18:04 nickpeihl

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 138 139 +1
links 130 126 -4
total -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 463 468 +5
links 57 4 -53
total -48

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 23.0KB 34.9KB +11.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 12 11 -1
links 6 0 -6
total -7

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.1KB 70.3KB +248.0B
links 33.8KB 25.1KB -8.7KB
total -8.4KB
Unknown metric groups

API count

id before after diff
embeddable 573 578 +5
links 57 4 -53
total -48

History

  • :broken_heart: Build #207942 failed 6e2c83f915714ece533fd1bee62fce3d6358e9c7
  • :green_heart: Build #207625 succeeded fb45d4590bf45d17dfa2c3d369d8c84a0c1bcec6
  • :broken_heart: Build #207583 failed b5b240d33cda3a961dd84b266242915fc1bce030
  • :yellow_heart: Build #206631 was flaky 920f143c3e856232b907a295c7e579df7961c66d
  • :broken_heart: Build #206464 failed 124e91dcb0fe968975a7d0208d04e21d25d9b2f8

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar May 06 '24 15:05 kibana-ci

Note for reviewers: This currently has a bug where by-reference Links panels do not apply dynamic panel sizes because the attributes are only loaded in the buildEmbeddable method. This will be fixed when https://github.com/elastic/kibana/pull/182523 lands.

nickpeihl avatar May 07 '24 18:05 nickpeihl

/ci

nickpeihl avatar Jun 21 '24 16:06 nickpeihl

/ci

nickpeihl avatar Jun 21 '24 18:06 nickpeihl

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
links 131 128 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
links 57 4 -53

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 495.2KB 495.2KB -13.0B
links 23.0KB 34.6KB +11.6KB
total +11.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
links 6 0 -6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.7KB 70.7KB -31.0B
links 33.8KB 26.3KB -7.4KB
presentationPanel 43.5KB 43.6KB +103.0B
total -7.4KB
Unknown metric groups

API count

id before after diff
links 57 4 -53

References to deprecated APIs

id before after diff
links 4 3 -1

History

  • :yellow_heart: Build #217503 was flaky 1d144682f7f5ad302518dc5a882d6d9cfb7eba8c
  • :broken_heart: Build #217227 failed 7059ddcf077ffdf6f8226dcf86629893d91bc149
  • :broken_heart: Build #217200 failed 209175d86b0cf610adce0248e607eb2a82b2347c
  • :green_heart: Build #208480 succeeded ba92badd9df63551e811053641a4ff70113cb012
  • :green_heart: Build #208157 succeeded 8e74c1c16ab5b32db770dffa0016febd8c3eb999
  • :broken_heart: Build #207942 failed 6e2c83f915714ece533fd1bee62fce3d6358e9c7

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Jun 25 '24 15:06 kibana-ci

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
links 131 127 -4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
links 58 5 -53

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 503.6KB 503.6KB -13.0B
links 23.0KB 43.8KB +20.8KB
total +20.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
links 6 0 -6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 71.3KB 71.3KB -31.0B
links 33.9KB 22.1KB -11.7KB
total -11.8KB
Unknown metric groups

API count

id before after diff
links 58 5 -53

async chunk count

id before after diff
links 2 4 +2

References to deprecated APIs

id before after diff
links 4 3 -1

History

  • :broken_heart: Build #219932 failed bf4b1c23bc9c6006a0c1b812bdc3a270fa94a6b1
  • :green_heart: Build #219514 succeeded 03d0edaaf4a2e7db6a1ac9d1ac65bb89266072a9
  • :yellow_heart: Build #219456 was flaky 210213d1ff9b3699e1a1d1d59fbffac1b06e3668

elasticmachine avatar Jul 05 '24 20:07 elasticmachine