kibana
kibana copied to clipboard
elastic
[Unified Search] Hide ES|QL ad hoc data views from the data view picker
Summary
This PR hides ES|QL ad hoc data views from the data view list in the Unified Search data view picker since they are an implementation detail and should not be visible to users.
Resolves #170098. Resolves #166911. Partially addresses #176873.
Checklist
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [x] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
Should we also hide it from Alerts data view picker?
@jughosta Good catch! I updated the approach to do the filtering within the DataViewsList component used by both the data view picker and the alerts flyout. Doing it this way also means other consumers can get the filtering for free as long as they include type in their data view list items: https://github.com/elastic/kibana/pull/177109/commits/fccf8a70dc7707dfa388241008269c7c4840ffdd.
cc @stratoula in case you want to do another quick review since I changed the approach slightly.
:green_heart: Build Succeeded
- Buildkite Build
- Commit: eb6703dfa49a1edd712849790405ea50a98f1ebe
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
unifiedSearch |
233 | 235 | +2 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
discover |
580.1KB | 580.1KB | -12.0B |
unifiedSearch |
225.3KB | 225.5KB | +278.0B |
| total | +266.0B |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
stackAlerts |
24.4KB | 24.4KB | +12.0B |
History
- :yellow_heart: Build #194812 was flaky 9133f7b723ce4dcb21bca1f09e3b43189663fb0e
- :green_heart: Build #194768 succeeded 8570b300439d379d1af4cb49d6a6ffd11e38e96e
- :yellow_heart: Build #194541 was flaky 6a6241e683fc82f8adfc3e6c3014a576f15d93ac
- :green_heart: Build #194274 succeeded 904841c82d5c5aa578a5b0b9ae90e7d5212e0213
- :green_heart: Build #194004 succeeded 5e40bb3ddd8e93b25fa682a51778697250471652
- :broken_heart: Build #193999 failed 70587244b505f500c99236922adce4ef23e2f56f
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @davismcphee
