kibana
kibana copied to clipboard
elastic
[ML] Fixes ES|QL field stats showing skewed numeric distribution, duplicated examples for string fields, and add functional tests
Summary
Part of https://github.com/elastic/kibana/issues/173301. This PR:
- Fixes ES|QL field stats showing skewed numeric distribution, duplicated examples for string fields
- Adds functional tests for ES|QL data visualizer view
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Flaky Test Runner was used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 4f8e6320d0f6ac4e03811aa4070960bf8ab36a61
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
dataVisualizer |
653.4KB | 653.6KB | +235.0B |
History
- :green_heart: Build #195097 succeeded 156562a2b305fedc9ece039e2198c7cbabe72b28
- :green_heart: Build #195023 succeeded c26b7f45fd54327a6875dcbaa57a4c2f67c6ed07
- :yellow_heart: Build #194217 was flaky 11ccf5387ec05f33417cd922ba520c65382c300e
- :yellow_heart: Build #194026 was flaky 8b0e10872ecb0b45cd25bd6197990e1255c65559
- :broken_heart: Build #193953 failed a5721a38225b8e9d4678f1405e27f1752e462c81
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @qn895
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.13 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.13 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation
