kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Unified Search bad intractability on narrow screen

Open nickofthyme opened this issue 1 year ago • 2 comments

Kibana version:

8.13, latest

Describe the bug:

When using an app such as discover with unified search, when the query bar width is overly confided such that the time picker is pushed to a new row the UI unnecessarily jumps around a lot. Main contributing factors of this are...

  • Narrow browser window, especially in serverless with the side nav open.
  • A wide time picker display (i.e. both start and end are absolute times)

The problem is that in this state where the time picker is pushed to a second row, as soon as the user clicks the query bar, the timepicker width is collapsed causing the time picker to move back to the first row and jumps all the content up with it to remove the now empty row. Then blurring the query bar does the reverse and jumps the content down.

Expected behavior:

Ideally we prevent any collapsing of the time picker once it's pushed to the second row, as there's no longer a need to make more room for the query bar in this state, in fact doing so currently actually reduces the query bar width.

Screenshots (if relevant):

https://github.com/elastic/kibana/assets/19007109/0ded5006-a568-4418-9253-1feaf4c138de

Notice when focusing and blurring the query bar how the entire page contents jump up and down.

nickofthyme avatar Feb 15 '24 17:02 nickofthyme

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine avatar Feb 15 '24 17:02 elasticmachine

I am changing this to enhancement because:

  • it is something we know and we had agreed to keep it like that
  • responsiveness is not great in kibana in general
  • there are some conversations about redesign so I think it will be good to deal with responsiveness after the redesign

stratoula avatar Feb 18 '24 07:02 stratoula

I agree, this just caused a failure in the functional tests with the shift causing unnecessary chart rerenders. Just wanted to make note of this for future enhancement.

nickofthyme avatar Feb 19 '24 21:02 nickofthyme

How this causes rerenders to the FT? Are we resizing or something? 🤔

stratoula avatar Feb 20 '24 06:02 stratoula

How this causes rerenders to the FT? Are we resizing or something? 🤔

In the serverless environment with the side nav open making discover narrower, you have the TimePicker pushed to the bottom. In one functional test, the test focuses the query bar then blurs it for some assertion. This blurring of the query bar causes the collapse of the time picker and the chart container fills the space momentarily and causes the chart to render 3 additional times. To be clear this is not perceptible but the tests are asserting render count, which caused the error, see https://github.com/elastic/kibana/pull/176872#discussion_r1494368292.

nickofthyme avatar Feb 20 '24 16:02 nickofthyme

Yes thanx Nick, it is clear now :)

stratoula avatar Feb 20 '24 16:02 stratoula