kibana [Fleet] Fix output encryption when AAD fields or encrypted field change

[Fleet] Fix output encryption when AAD fields or encrypted field change

Open nchaulet opened this issue 4 months ago • 10 comments

Description

Resolve https://github.com/elastic/kibana/issues/176702 That PR fix output saved object encryption error when editing field that are included in AAD or an encrypted field.

For this that PR make sure that we include all required AAD field when updating an encrypted field, and that we update encrypted field when updating a required AAD field.

Tests

I added some unit tests to cover that

You can manually test this by creating a preconfigured output with allow_edit

xpack.fleet.outputs:
  - name: 'Test output'
    is_default: true
    is_default_monitoring: true
    type: 'logstash'
    id: 'output-123'
    hosts: ['elasticsearch:9200']
    allow_edit: ['ssl', 'secrets', 'test']
    ssl:
      certificate: 'replace2'
      key: 'replacet'

then update allow_edit to remove the test value, you can also check that you can update ssl certificate in the UI

Feb 13 '24 16:02 nchaulet

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Feb 13 '24 16:02 apmmachine

/ci

Feb 14 '24 16:02 nchaulet

Pinging @elastic/fleet (Team:Fleet)