kibana
kibana copied to clipboard
[ML] Anomaly Detection: Fix anomaly marker click in Single Metric Viewer embeddable
Summary
Part of #176651 and #153476.
Fixes the click on anomaly markers in the Single Metric Viewer embeddable. This required refactoring some dependencies to be properly passed in via React contexts instead of the legacy dependency cache.
smv-embeddable-click-0001.webm
Checklist
- [x] Unit or functional tests were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was labeled appropriately
Pinging @elastic/ml-ui (:ml)
Gave this another test and getting blank charts now along with this toast:
Looks like the job service has a dependency cache dependency that could be causing issues. I think it tries to use the http service from the dependency cache. Getting these errors in console:
For this ^ looks like the path might be wrong - I think it should be this.context.services.mlServices.mlApiServices.results
@alvarezmelissa87 Thanks for the testing and spotting the errors!
- The first toast is not related to this PR, you need to update your ES instance because the Kibana data views service makes use of new functionality.
- I was able to fix
mlJobService
to make it work in embeddables in 3ee830d. - Well spotted on the wrong
context
access formlApiServices.results
, that one's fixed too.
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: cef71e50cf7f43a8a211f08fd770a5db64850fbb
Failed CI Steps
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
ml |
3.7MB | 3.7MB | +12.9KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
ml |
79.0KB | 78.4KB | -691.0B |
Unknown metric groups
async chunk count
id | before | after | diff |
---|---|---|---|
ml |
44 | 45 | +1 |
ESLint disabled line counts
id | before | after | diff |
---|---|---|---|
ml |
560 | 563 | +3 |
Total ESLint disabled count
id | before | after | diff |
---|---|---|---|
ml |
563 | 566 | +3 |
History
- :yellow_heart: Build #194071 was flaky d4e6b66aed275bef59054ede6844d9c50376e6c8
- :yellow_heart: Build #193795 was flaky bcda5682b5a9388b52565629ed113ac257bce690
- :broken_heart: Build #193774 failed 9333edccd633591ea00dcdca1380f631d6d6778a
- :green_heart: Build #193662 succeeded bccd244fb9f82e32aed1e50fa7e56dff42852b6a
- :yellow_heart: Build #193560 was flaky f57c08d870b943a8bdcb42162c21f07172ccad84
- :broken_heart: Build #193530 failed 70ab770cc5e06985dba0dd7b86123eee21f7a72e
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @walterra