[Dataset quality] Filters for timeRange, integrations and datasetQuery

[yngrdyn]

Closes https://github.com/elastic/kibana/issues/170242

[apmmachine]

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mohamedhamed-ahmed]

I played around with the PR and got some questions:

• Should the time filter also apply to the Size column in the table, so that I see the size in the specified time range?
• Should we maybe allow the search bar to filter more than just the dataset name? I see the AC says searches the dataset name by default but what if I want to filter all dataset with size>20mb for example
• I am unable to select 2 datasets from different integrations together using the search bar, is there a way we can achieve this?
• Should we maybe rename the None to Uncategorized?
• Filtering and removing the filters, rerequests the table data again. Do we really need to do this? especially if the user has so many datasets this will take a long time as they search and remove the search.

[mohamedhamed-ahmed]

The page contents shift a bit when the table content changes, can we keep this fixed as it feels a bit annoying

https://github.com/elastic/kibana/assets/11225826/137c86c1-ccc9-441d-bbe1-c9a2231d94b9

[yngrdyn]

Should we maybe allow the search bar to filter more than just the dataset name? I see the AC says searches the dataset name by default but what if I want to filter all dataset with size>20mb for example

I am unable to select 2 datasets from different integrations together using the search bar, is there a way we can achieve this?

We are quite limited regarding the search bar, mainly because of the DataStreams API, there we are only able to filter using a pattern

Should we maybe rename the None to Uncategorized?

This was already discussed in the figma file.

Filtering and removing the filters, rerequests the table data again. Do we really need to do this? especially if the user has so many datasets this will take a long time as they search and remove the search.

This is good point! I'll take a look on this one

[yngrdyn]

As we discussed offline, I will switch to UI filtering instead of going to our endpoint and filter using the dataStreams API, filtering in the UI will give more flexibility than just having a pattern. Users for example would be able to filter two datasets that comes from different integrations with a multi select (as they can do for example for integrations)

[kibana-ci]

:yellow_heart: Build succeeded, but was flaky

• Buildkite Build
• Commit: f45313b299bffec273902bfd8ef12d0a1f0c5afa

Failed CI Steps

• FTR Configs #62

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
datasetQuality	156	167	+11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/timerange	-	8	+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
datasetQuality	118.8KB	136.3KB	+17.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
datasetQuality	29.9KB	31.4KB	+1.5KB
observabilityLogsExplorer	12.8KB	12.9KB	+151.0B
total			+1.7KB

Unknown metric groups

API count

id	before	after	diff
@kbn/timerange	-	8	+8

async chunk count

id	before	after	diff
datasetQuality	8	9	+1

ESLint disabled line counts

id	before	after	diff
datasetQuality	9	10	+1

Total ESLint disabled count

id	before	after	diff
datasetQuality	11	12	+1

History

• :green_heart: Build #194140 succeeded d5cb1be8b8ab64a6686dd61537289706e5c47197
• :yellow_heart: Build #193856 was flaky 6e696aec8c50d11b2beb4bc03154c96deee9fb02
• :broken_heart: Build #193624 failed 8fd4bdb0bd4941da818443accb9a9c9adfe33e04
• :green_heart: Build #193594 succeeded 66feb03fc5c41fda146587039bb61502059e49c3
• :broken_heart: Build #193564 failed 000986c12b8d1f7f0aa2d4c81efa01975b6e908d
• :broken_heart: Build #193528 failed 40cd1e852d1da9b97cfe6f9304dcf0a7e58734ef

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @yngrdyn

[elasticmachine]

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)