chore(NA): upgrade typescript into v4.9.5

[mistic]

This PR bumps the Typescript version used on Kibana into v4.9.5. The full set of changes can be found here. So far, as long I can see, the performance is better than in the version we're currently in.

I didn't want to make assumptions for such a diversity of type errors across the codebase so instead I choose to mark the failures with @ts-expect-error and let each team decide how to handle it.

There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.

Here it goes the list for follow up:

@elastic/kibana-core - tracking issue: https://github.com/elastic/kibana/issues/176153

• [ ] packages/analytics/client/src/analytics_client/analytics_client.ts
• [ ] packages/analytics/client/src/analytics_client/context_service.ts
• [ ] packages/analytics/client/src/analytics_client/types.ts
• [ ] packages/core/http/core-http-router-server-internal/src/validator.ts
• [ ] packages/core/http/core-http-server-internal/src/cookie_session_storage.ts
• [ ] packages/core/plugins/core-plugins-server-internal/src/create_browser_config.ts
• [ ] packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/apis/bulk_update.ts
• [ ] packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/apis/update.ts
• [ ] packages/kbn-es-types/src/search.ts
• [ ] packages/kbn-utility-types/src/dot.ts
• [ ] src/core/server/mocks.ts
• [ ] test/plugin_functional/test_suites/core_plugins/rendering.ts

@elastic/kibana-presentation

• [ ] packages/content-management/content_editor/src/jest/tests.helpers.tsx
• [ ] src/plugins/embeddable/public/lib/embeddables/embeddable_factory.ts
• [ ] src/plugins/presentation_util/public/services/create/provider.tsx
• [ ] x-pack/plugins/canvas/canvas_plugin_src/functions/server/pointseries/index.ts
• [ ] x-pack/plugins/canvas/server/templates/status_report.ts
• [ ] x-pack/plugins/canvas/server/templates/summary_report.ts
• [ ] x-pack/plugins/canvas/types/arguments.ts
• [ ] x-pack/plugins/canvas/types/functions.ts

@elastic/apm

• [ ] packages/kbn-apm-synthtrace-client/src/lib/interval.ts
• [ ] packages/kbn-apm-synthtrace/src/lib/shared/get_serialize_transform.ts
• [ ] packages/kbn-apm-synthtrace/src/lib/utils/with_client.ts
• [ ] x-pack/plugins/apm/server/lib/helpers/transactions/get_is_using_transaction_events.test.ts

@elastic/obs-knowledge-team

• [ ] packages/kbn-io-ts-utils/src/to_json_schema/index.ts
• [ ] packages/kbn-server-route-repository/src/test_types.ts

@elastic/security-detection-engine

• [ ] packages/kbn-securitysolution-io-ts-alerting-types/src/threat_mapping/index.test.ts
• [ ] packages/kbn-securitysolution-utils/src/add_remove_id_to_item/index.ts
• [ ] x-pack/plugins/lists/server/routes/utils/build_siem_response.ts

@elastic/appex-sharedux

• [ ] packages/shared-ux/router/impl/routes.tsx
• [ ] src/plugins/files/server/routes/file_kind/enhance_router.ts
• [ ] src/plugins/files/server/routes/types.ts

@elastic/kibana-visualizations

• [x] src/plugins/chart_expressions/expression_legacy_metric/public/stories/metric_renderer.stories.tsx
• [x] src/plugins/chart_expressions/expression_legacy_metric/public/components/with_auto_scale.tsx
• [x] src/plugins/expressions/common/execution/execution_contract.ts
• [x] src/plugins/vis_types/table/public/components/table_vis_basic.test.tsx
• [x] src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/percentile.ts
• [x] src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/percentile_rank.ts
• [x] src/plugins/visualizations/public/vis.ts
• [x] src/plugins/visualizations/public/vis_async.ts
• [ ] x-pack/plugins/lens/public/datasources/form_based/operations/definitions/formula/formula.test.tsx
• [x] x-pack/plugins/lens/public/debounced_component/debounced_component.tsx
• [ ] x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx
• [ ] x-pack/plugins/lens/public/embeddable/expression_wrapper.tsx
• [x] x-pack/plugins/lens/public/state_management/lens_slice.ts
• [x] x-pack/plugins/lens/server/migrations/common_migrations.ts
• [ ] src/plugins/embeddable/public/registry/saved_object_to_panel_methods.ts

@elastic/kibana-data-discovery

• [ ] src/plugins/data_view_management/public/components/test_utils.tsx
• [ ] src/plugins/unified_histogram/public/layout/layout.tsx

@elastic/platform-deployment-management

• [ ] src/plugins/es_ui_shared/static/forms/hook_form_lib/components/use_field.tsx
• [ ] src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts
• [ ] src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field_from_props.ts
• [ ] src/plugins/es_ui_shared/static/forms/hook_form_lib/types.ts

@elastic/kibana-security

• [x] src/plugins/interactive_setup/public/use_form.ts

@elastic/ml-ui

• [ ] x-pack/packages/ml/cancellable_search/src/use_cancellable_search.ts
• [ ] x-pack/packages/ml/date_picker/src/components/full_time_range_selector.test.tsx
• [ ] x-pack/plugins/aiops/public/hooks/use_cancellable_search.ts
• [ ] x-pack/plugins/data_visualizer/public/application/data_drift/use_data_drift_result.ts

@elastic/response-ops

• [ ] x-pack/plugins/alerting/server/application/rule/methods/create/create_rule.ts
• [ ] x-pack/plugins/alerting/server/application/rule/methods/resolve/types/resolved_rule.ts
• [ ] x-pack/plugins/alerting/server/routes/get_rule.test.ts
• [ ] x-pack/plugins/alerting/server/routes/lib/rewrite_rule.test.ts
• [ ] x-pack/plugins/alerting/server/routes/rule/apis/create/create_rule_route.test.ts
• [ ] x-pack/plugins/cases/public/api/utils.ts
• [ ] x-pack/plugins/cases/public/components/case_view/components/user_list.test.tsx
• [ ] x-pack/plugins/stack_connectors/public/connector_types/opsgenie/params.test.tsx
• [ ] x-pack/plugins/triggers_actions_ui/public/application/lib/suspended_component_with_props.tsx
• [ ] x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_alerts_filter_timeframe.test.tsx
• [ ] x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_conditions.tsx
• [ ] x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_conditions_group.tsx

@elastic/security-threat-hunting-investigations

• [ ] x-pack/plugins/ecs_data_quality_dashboard/server/lib/build_response/index.ts

@elastic/security-generative-ai

• [ ] x-pack/plugins/elastic_assistant/server/lib/build_response/index.ts

@elastic/enterprise-search-frontend

• [ ] x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/connector_total_stats.tsx
• [ ] x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler_total_stats.tsx
• [ ] x-pack/plugins/enterprise_search/public/applications/search_index/pipelines/pipelines_json_configurations_logic.ts
• [ ] x-pack/plugins/enterprise_search/public/applications/shared/accordion_list/accordion_list.test.tsx

@elastic/fleet

• [ ] x-pack/plugins/fleet/.storybook/context/fixtures/integration.nginx.ts
• [ ] x-pack/plugins/fleet/common/authz.test.ts
• [ ] x-pack/plugins/fleet/public/applications/fleet/sections/settings/hooks/use_confirm_modal.tsx
• [ ] x-pack/plugins/fleet/server/services/preconfiguration.ts

@elastic/platform-deployment-management

• [ ] x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/form_errors_context.tsx

@elastic/obs-ux-logs-team / @elastic/obs-ux-infra_services-team

• [ ] x-pack/plugins/infra/public/containers/metrics_source/source.tsx
• [ ] x-pack/plugins/infra/public/pages/metrics/metric_detail/components/section.tsx
• [ ] x-pack/plugins/infra/public/pages/metrics/metric_detail/components/sub_section.tsx
• [ ] x-pack/plugins/logs_shared/public/components/logging/log_text_stream/vertical_scroll_panel.tsx
• [x] x-pack/plugins/observability_solution/logs_explorer/public/utils/proxies.ts
• [x] x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/form/validation.tsx
• [x] x-pack/plugins/synthetics/public/apps/synthetics/state/service_locations/api.ts
• [x] x-pack/plugins/synthetics/public/utils/api_service/api_service.ts
• [x] x-pack/plugins/synthetics/server/routes/types.ts
• [x] x-pack/plugins/synthetics/server/synthetics_service/service_api_client.ts
• [x] x-pack/plugins/uptime/public/legacy_uptime/components/common/monitor_tags.test.tsx
• [x] x-pack/plugins/uptime/public/legacy_uptime/state/api/utils.ts
• [x] x-pack/plugins/uptime/public/utils/api_service/api_service.ts
• [x] x-pack/plugins/uptime/server/legacy_uptime/lib/requests/get_snapshot_counts.ts
• [x] x-pack/plugins/uptime/server/legacy_uptime/lib/requests/search/find_potential_matches.ts
• [x] x-pack/plugins/uptime/server/legacy_uptime/lib/requests/search/query_context.ts
• [x] x-pack/plugins/uptime/server/legacy_uptime/lib/requests/search/refine_potential_matches.ts
• [x] x-pack/plugins/uptime/server/legacy_uptime/routes/types.ts
• [x] x-pack/plugins/ux/public/application/ux_app.tsx
• [x] x-pack/plugins/ux/public/components/app/rum_dashboard/ux_overview_fetchers.ts

@elastic/kibana-gis

• [ ] x-pack/plugins/maps/public/classes/sources/es_source/es_source.ts
• [ ] x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx
• [ ] x-pack/plugins/maps/public/classes/styles/vector/symbol_utils.tsx
• [ ] x-pack/plugins/maps/public/lazy_wrapper.tsx

@elastic/observability-ui

• [ ] x-pack/plugins/observability_shared/public/contexts/inspector/inspector_context.tsx

@elastic/security-defend-workflows

• [ ] x-pack/plugins/osquery/common/utility_types.ts

@elastic/security-solution

• [ ] x-pack/plugins/security_solution/common/endpoint/generate_data.ts
• [ ] x-pack/plugins/security_solution/common/utility_types.ts
• [ ] x-pack/plugins/security_solution/public/common/components/page/manage_query.tsx
• [ ] x-pack/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/network/dns_top_domains.ts
• [ ] x-pack/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/users/kpi_user_authentication_metric_failure.ts
• [ ] x-pack/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/users/kpi_user_authentications_area.ts
• [ ] x-pack/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/users/kpi_user_authentications_bar.ts
• [ ] x-pack/plugins/security_solution/public/common/components/visualization_actions/lens_attributes/users/kpi_user_authentications_metric_success.ts
• [ ] x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts
• [ ] x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components/description_step/index.tsx
• [ ] x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx
• [ ] x-pack/plugins/security_solution/scripts/endpoint/common/agent_downloads_service.ts
• [ ] x-pack/plugins/security_solution/server/endpoint/services/actions/clients/mocks.ts
• [ ] x-pack/plugins/security_solution/server/lib/detection_engine/routes/utils.ts
• [ ] x-pack/plugins/security_solution/server/lib/detection_engine/rule_management/logic/bulk_actions/utils.ts
• [ ] x-pack/plugins/security_solution/server/lib/detection_engine/rule_management/logic/bulk_actions/validations.ts
• [ ] x-pack/plugins/security_solution/server/lib/risk_score/prebuilt_dev_tool_content/routes/read_prebuilt_dev_tool_content_route.ts

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[mistic]

@banderror as I mentioned in the PR description, feel free to open a PR against my branch and I will merge it into this one or follow up in a new one after this gets merged 😃

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[kibana-ci]

:yellow_heart: Build succeeded, but was flaky

• Buildkite Build
• Commit: 3d270ad850e8e498475c5d79c9ae720a0f284106
• Storybooks Preview

Failed CI Steps

• Defend Workflows Cypress Tests #5

Test Failures

• [job] [logs] Defend Workflows Cypress Tests #5 / Response console Host Isolation: should isolate a host from response console should isolate a host from response console

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionLegacyMetricVis	11.9KB	11.9KB	-10.0B
visTypeTimeseries	514.3KB	514.3KB	+8.0B
total			-2.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
observabilityShared	19	20	+1

History

• :yellow_heart: Build #195379 was flaky 8b3f4826203319656c7ec489edae52de798257f7
• :broken_heart: Build #195377 failed 3411e28a81f82d841a5f3a4dc007e5ed9f89f12b
• :broken_heart: Build #195366 failed e9fe384d2962fba85146d3ffc89c2dd0855f974b
• :broken_heart: Build #195362 failed 3a8ba61f53b4f4c341a1150c4f7bfdfa2c709889
• :broken_heart: Build #194104 failed 177f8c99bb67142e95b4cb20ad68487c2f7c041d
• :broken_heart: Build #193993 failed 8789f21161d26d494eb7bc80d40c1b2437848020

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

[mistic]

I've went ahead and merged this one. The missing places with a ts-expect-error to be fixed can be found in the description of the PR. Please let me know if you have any other feedback.

[delanni]

Cross-referencing #160033 for discoverability