kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[ML] Fix Data visualizer/Field stats not updating distribution when changing shard size

Open qn895 opened this issue 2 years ago • 1 comments

Summary

This PR fixes a bug with the Data visualizer/Field stats not updating distribution when changing shard size.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

qn895 avatar Sep 21 '22 21:09 qn895

Pinging @elastic/ml-ui (:ml)

elasticmachine avatar Sep 21 '22 21:09 elasticmachine

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 568.4KB 568.5KB +18.0B
ml 3.4MB 3.4MB +116.0B
total +134.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
dataVisualizer 38 36 -2
ml 577 578 +1
total -1

Total ESLint disabled count

id before after diff
dataVisualizer 38 36 -2
ml 580 581 +1
total -1

History

  • :green_heart: Build #74642 succeeded 638362ca8e1e597058b289e13c7024990987beae

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @qn895

kibana-ci avatar Sep 22 '22 15:09 kibana-ci

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.4 Backport failed because of merge conflicts
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 141313

Questions ?

Please refer to the Backport tool documentation

kibanamachine avatar Sep 22 '22 17:09 kibanamachine

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

qn895 avatar Sep 22 '22 23:09 qn895