kibana
kibana copied to clipboard
elastic
[Security Solution] Removes flakiness from pinned filters
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 52926ae6bdd202047db882d523eafe99ba5c279b
Metrics [docs]
✅ unchanged
History
- :green_heart: Build #74555 succeeded d2b2e0ae08f36c46c396172e5f27d1e9d21d7d41
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @MadameSheema
💔 All backports failed
| Status | Branch | Result |
|---|---|---|
| ❌ | 8.5 | Backport failed because of merge conflicts You might need to backport the following PRs to 8.5: - :white_check_mark: add more unit tests for the annotation type switch operation (#141241) - [Fleet] Force unenroll in Agent activity (#141208) - [Actionable Observability][Metric Threshold Rule] Add histogram support to avg, max, min, sum and percentiles (#139770) - [Security Solution] Telemetry Task Metric Collector (#140503) - [Enterprise Search] fix ml pipeline name help text (#141311) |
Manual backport
To create the backport manually run:
node scripts/backport --pr 141269
Questions ?
Please refer to the Backport tool documentation
Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 141269 locally
Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 141269 locally
Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 141269 locally
Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 141269 locally
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.5 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation