kibana
kibana copied to clipboard
update visualizationType
Summary
origin issue: https://github.com/elastic/kibana/issues/139786
Steps to verify:
- On hosts / network / users page
- Trigger a chart action, and
Open in Lens
- Please check the visualization you see is aligned with security solution.
- On Lens page's top right corner, click
Inspect
. If it is not a metric, make sure the column title exists.
Before:
https://user-images.githubusercontent.com/59917825/190333492-e131904d-12d5-4b4a-86c8-bfb2adb17292.mp4
After:
Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [x] Unit or functional tests were updated or added to match the most common scenarios
Pinging @elastic/security-threat-hunting (Team:Threat Hunting)
Pinging @elastic/security-solution (Team: SecuritySolution)
... If it is not a metric, make sure the column title exists
Silly question: Why metrics don't have column names?
... If it is not a metric, make sure the column title exists
Silly question: Why metrics don't have column names?
@machadoum Because the column name will be displayed at top of the metric as well. Considering that we might replace the current metric with visualization in the future, we do not provide column name to metric to maintain the layout consistency.
If we add column name to a metric, the label appears to the top of the metric too:
However our current design only shows the number. To make the metric visualisation the same as what we have atm, we do not add label to metric.
I am not very comfortable with the extensive usage of snapshot tests in the code base, primarily due to its complex maintenance.
I won't block the PR because it is a personal opinion.
I understand. It's just I can't think of a better way to avoid those templates being changed without awareness. Those references and filters have to be replaced with what we have from the sourcerer, and their labels have to be aligned with what we have in current UI.
:green_heart: Build Succeeded
- Buildkite Build
- Commit: b2b11f44dd5cae2037a619db68570c50d3f57631
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
securitySolution |
6.6MB | 6.6MB | +1.0KB |
History
- :green_heart: Build #75514 succeeded 8f80e9266870866bf15c70a8964c03a901616bc3
- :broken_heart: Build #74752 failed 0279513f788d019712530f0d6885c632a1177db9
- :broken_heart: Build #74630 failed 0d4948311732466db35212eefd8a49ad13305b80
- :broken_heart: Build #74456 failed 80642db7b166cff153801466f7f65e8ca51a311c
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
💚 All backports created successfully
Status | Branch | Result |
---|---|---|
✅ | 8.5 |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation