kibana icon indicating copy to clipboard operation
kibana copied to clipboard

update visualizationType

Open angorayc opened this issue 2 years ago • 1 comments

Summary

origin issue: https://github.com/elastic/kibana/issues/139786

Steps to verify:

  • On hosts / network / users page
  • Trigger a chart action, and Open in Lens
  • Please check the visualization you see is aligned with security solution.
  • On Lens page's top right corner, click Inspect. If it is not a metric, make sure the column title exists.

Before:

image

https://user-images.githubusercontent.com/59917825/190333492-e131904d-12d5-4b4a-86c8-bfb2adb17292.mp4

After: Screenshot 2022-09-21 at 21 53 31 Screenshot 2022-09-21 at 21 54 01 Screenshot 2022-09-21 at 21 54 13

Checklist

Delete any items that are not applicable to this PR.

angorayc avatar Sep 21 '22 13:09 angorayc

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine avatar Sep 26 '22 14:09 elasticmachine

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine avatar Sep 26 '22 14:09 elasticmachine

... If it is not a metric, make sure the column title exists

Silly question: Why metrics don't have column names?

machadoum avatar Sep 27 '22 08:09 machadoum

... If it is not a metric, make sure the column title exists

Silly question: Why metrics don't have column names?

@machadoum Because the column name will be displayed at top of the metric as well. Considering that we might replace the current metric with visualization in the future, we do not provide column name to metric to maintain the layout consistency.

If we add column name to a metric, the label appears to the top of the metric too: Screenshot 2022-09-27 at 10 49 16

However our current design only shows the number. To make the metric visualisation the same as what we have atm, we do not add label to metric. Screenshot 2022-09-27 at 10 49 26

angorayc avatar Sep 27 '22 09:09 angorayc

I am not very comfortable with the extensive usage of snapshot tests in the code base, primarily due to its complex maintenance.

I won't block the PR because it is a personal opinion.

I understand. It's just I can't think of a better way to avoid those templates being changed without awareness. Those references and filters have to be replaced with what we have from the sourcerer, and their labels have to be aligned with what we have in current UI.

angorayc avatar Sep 27 '22 10:09 angorayc

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +1.0KB

History

  • :green_heart: Build #75514 succeeded 8f80e9266870866bf15c70a8964c03a901616bc3
  • :broken_heart: Build #74752 failed 0279513f788d019712530f0d6885c632a1177db9
  • :broken_heart: Build #74630 failed 0d4948311732466db35212eefd8a49ad13305b80
  • :broken_heart: Build #74456 failed 80642db7b166cff153801466f7f65e8ca51a311c

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Sep 28 '22 09:09 kibana-ci

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

angorayc avatar Oct 04 '22 11:10 angorayc