kibana
kibana copied to clipboard
elastic
[ML] Fix Open in Single Metric Viewer links not reflecting custom time range for Anomaly chart embeddables
Summary
This PR addresses https://github.com/elastic/kibana/issues/139740 and fixes an issue with View/Open in Single Metric Viewer not reflecting the custom time range for Anomaly charts embeddables in Dashboard and in Cases.
Navigating from Dashboard with custom panel time range:
https://user-images.githubusercontent.com/43350163/191119008-42a369bc-24b0-4803-a885-0b700b98b117.mov
Navigating from Dashboard with global time picker time range (which is the default if panel doesn't have time range applied):
https://user-images.githubusercontent.com/43350163/191118564-3196933b-17b7-4fe6-9c35-1502d5c3b446.mov
Navigating from Cases:
https://user-images.githubusercontent.com/43350163/191118514-292dfdbc-44dd-461c-ac46-8d951194f405.mov
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:green_heart: Build Succeeded
- Buildkite Build
- Commit: c098d3c7c3d7b82844136024fa22c2674d577249
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
ml |
3.4MB | 3.4MB | +135.0B |
History
- :green_heart: Build #74609 succeeded 696601b08fcfb3ad385fd20ce5a8c6fb75806511
- :broken_heart: Build #74550 failed c09a547d1dd8f7acfacada6157ce17f811af9d81
- :broken_heart: Build #73661 failed ce7b36a9859b0b396549da86a75ef3783b228eec
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @qn895
💔 Some backports could not be created
| Status | Branch | Result |
|---|---|---|
| ❌ | 7.17 | Backport failed because of merge conflicts |
| ❌ | 8.4 | Backport failed because of merge conflicts |
| ✅ | 8.5 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Manual backport
To create the backport manually run:
node scripts/backport --pr 141007
Questions ?
Please refer to the Backport tool documentation
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 8.4 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 7.17 |  |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.