[Portable Dashboards] Remove Saved Object Class

[ThomThomson]

Summary

Major WIP: Fixes https://github.com/elastic/kibana/issues/137200 Fixes https://github.com/elastic/kibana/issues/136767

This PR will require extremely thorough testing

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[ThomThomson]

@Heenawter - I was able to fix the bug you described in https://github.com/elastic/kibana/pull/138774#pullrequestreview-1119032685. Nice catch! It was basically a matter of correctly applying all of the state from the save modal. I also cleaned up the state comparison of times a little bit to make it match with the rest of the state comparison.

[ThomThomson]

@elasticmachine merge upstream

[jbudz]

buildkite test this

[ThomThomson]

@elasticmachine merge upstream

[kibana-ci]

:green_heart: Build Succeeded

• Buildkite Build
• Commit: 474b6ed78afb5a3a73f9a59b6981154523125c0d
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	395	385	-10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
dashboard	139	113	-26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	388.1KB	418.2KB	+30.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
dashboard	10	3	-7

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dashboard	72.2KB	41.0KB	-31.2KB

Unknown metric groups

API count

id	before	after	diff
dashboard	144	120	-24

async chunk count

id	before	after	diff
dashboard	5	8	+3

ESLint disabled line counts

id	before	after	diff
dashboard	8	7	-1

References to deprecated APIs

id	before	after	diff
dashboard	60	56	-4

Total ESLint disabled count

id	before	after	diff
dashboard	8	7	-1

Unreferenced deprecated APIs

id	before	after	diff
savedObjects	1	2	+1

History

• :broken_heart: Build #76534 failed 1fc1f55f977bff6ef77175f9d373f5a9349b9ab1
• :broken_heart: Build #76275 failed 1d93a4db7d861f8fa18dcede55e0aa5ace99638c
• :broken_heart: Build #76267 failed 61452cec22558e5b5e4f04a61d0bbf53a8678619
• :broken_heart: Build #76217 failed 05fb7eebfc2a36f8d8255132ce6fb241dccd56a5
• :green_heart: Build #75331 succeeded 26103a45bf4ab31408cde646d30166de0dc5bd45

To update your PR or re-run it, just comment with: @elasticmachine merge upstream