kibana icon indicating copy to clipboard operation
kibana copied to clipboard

[Security Solution] Host/User details flyout, fix ML narrow date range

Open stephmilovic opened this issue 2 years ago • 4 comments

Summary

Fixes a bug where the host/User details flyout ML Max anomaly score by job's "Narrow to this date range link" was not working, see issue https://github.com/elastic/kibana/issues/133102. The redux action was missing a dispatch call.

I also got rid of the snapshot test because those are naughty.

preconditions

  1. Kibana should be up and running
  2. Alerts should be triggered with ML anomaly score

Steps to Reproduce

  1. Navigate to Alerts page under security
  2. Click on host name details under host.name column of above generated alert
  3. Click on ML Anomaly score
  4. Click on "Narrow to this date range" link

Previous Result Narrow to this date range link is not working

New Result Narrow to this date range link updates the date range

werks

stephmilovic avatar Aug 09 '22 20:08 stephmilovic

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine avatar Aug 09 '22 20:08 elasticmachine

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine avatar Aug 09 '22 20:08 elasticmachine

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.6MB 5.6MB +248.0B

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibana-ci avatar Aug 09 '22 21:08 kibana-ci

@stephmilovic I ran a quick search and found that many places in the APP call setAbsoluteRangeDatePicker without dispatch.

https://github.com/elastic/kibana/blob/5c8eaa3ef92cec77388db69bee123c87981e71a6/x-pack/plugins/security_solution/public/users/pages/details/index.tsx#L161

https://github.com/elastic/kibana/blob/3246ec733e37f5fe7d00f11cb4903ea573bbbe27/x-pack/plugins/security_solution/public/users/pages/details/details_tabs.tsx#L43

https://github.com/elastic/kibana/blob/3246ec733e37f5fe7d00f11cb4903ea573bbbe27/x-pack/plugins/security_solution/public/users/pages/details/details_tabs.tsx#L58

https://github.com/elastic/kibana/blob/3246ec733e37f5fe7d00f11cb4903ea573bbbe27/x-pack/plugins/security_solution/public/users/pages/users_tabs.tsx#L42

https://github.com/elastic/kibana/blob/6efef0496077f4e61d49e4e43f75941ff3d98d9e/x-pack/plugins/security_solution/public/timelines/components/side_panel/host_details/expandable_host.tsx#L97

https://github.com/elastic/kibana/blob/241406a8df3a4b7ddd2ce01d889b88db403e7be0/x-pack/plugins/security_solution/public/network/pages/navigation/network_routes.tsx#L51

https://github.com/elastic/kibana/blob/241406a8df3a4b7ddd2ce01d889b88db403e7be0/x-pack/plugins/security_solution/public/network/pages/navigation/network_routes.tsx#L65

https://github.com/elastic/kibana/blob/3246ec733e37f5fe7d00f11cb4903ea573bbbe27/x-pack/plugins/security_solution/public/hosts/pages/hosts_tabs.tsx#L47

machadoum avatar Aug 10 '22 09:08 machadoum

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine avatar Aug 10 '22 13:08 kibanamachine