kibana
kibana copied to clipboard
Lens embeddables/hosts
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk | Probability | Severity | Mitigation/Notes |
---|---|---|---|
Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: 833cc613885eb54153fdd7216c869222ac83f821
Failed CI Steps
Test Failures
- [job] [logs] Security Solution Tests #1 / Alerts timeline Privileges: can crud should allow a user with crud privileges to attach alerts to cases
- [job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before all" hook for "should be able to update timeline kqlMode with filter"
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
id | before | after | diff |
---|---|---|---|
securitySolution |
3040 | 3045 | +5 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
lens |
1.2MB | 1.2MB | +30.0B |
securitySolution |
5.4MB | 5.4MB | +5.0KB |
total | +5.1KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
lens |
34.5KB | 34.6KB | +58.0B |
securitySolution |
255.0KB | 255.2KB | +192.0B |
total | +250.0B |
History
- :yellow_heart: Build #65776 was flaky 57b679fb9a4804e4384e5b1d4fb2d99fa3102e06
- :broken_heart: Build #65720 failed 7c64e37da42b430602ea51f70ee8c76d36ba2f6c
- :broken_heart: Build #65384 failed bb5fbbe1e1e67e5e11ffb091c45083fd8f4392fd
- :green_heart: Build #65072 succeeded 424330d931e1a3b6606eacb8caae485b31290db4
- :broken_heart: Build #65038 failed 270cbc8bae3842f5c35c9b0335998ab2eb42f996
- :broken_heart: Build #64815 failed 32fab08d2d0d1d70d6fa28ff26e5464a61abd3e7
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
Pinging @elastic/security-threat-hunting (Team:Threat Hunting)
Pinging @elastic/security-solution (Team: SecuritySolution)
@angorayc I noticed some weird-looking UI. Let me know if it is a problem with my environment.
When I open the host page I get an error and dark background behind the scroll bar and a black square in the header.
When I open it on a smaller screen:
Loading state
Empty state:
When loaded:
Hey @machadoum , thanks for catching this. I think that's because source.ip and destination.ip both have conflict in their field. Lens doesn't seem to allow aggregation on a non keyword type, but our current charts are retrieving data from Elasticsearch api, which doesn't show error in this case. Guessing that's why we have the inconsistency between current charts and Lens Embeddables. I'm asking Lens' opinion on how to fix this https://elastic.slack.com/archives/C013C7Z2X8W/p1667905889860969 Update: Lens team has this issue open: https://github.com/elastic/kibana/issues/143673



:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: a1a77d3a5afaf32b66cb63e394149104c907dcde
Failed CI Steps
Test Failures
- [job] [logs] Security Solution Tests #1 / Cases Creates a new case with timeline and opens the timeline
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
id | before | after | diff |
---|---|---|---|
securitySolution |
3204 | 3214 | +10 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
securitySolution |
9.6MB | 9.6MB | +10.7KB |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
securitySolution |
50.6KB | 50.6KB | +27.0B |
Unknown metric groups
ESLint disabled in files
id | before | after | diff |
---|---|---|---|
osquery |
1 | 2 | +1 |
ESLint disabled line counts
id | before | after | diff |
---|---|---|---|
enterpriseSearch |
19 | 21 | +2 |
fleet |
59 | 65 | +6 |
osquery |
108 | 113 | +5 |
securitySolution |
440 | 446 | +6 |
total | +19 |
Total ESLint disabled count
id | before | after | diff |
---|---|---|---|
enterpriseSearch |
20 | 22 | +2 |
fleet |
67 | 73 | +6 |
osquery |
109 | 115 | +6 |
securitySolution |
517 | 523 | +6 |
total | +20 |
History
- :green_heart: Build #86208 succeeded 6e21f27d44319cf90efbbcb4c64f587c68ef558a
- :broken_heart: Build #86109 failed 28d192e3e596cf4f3e492e13bf08fd5670dd55ab
- :broken_heart: Build #86040 failed f85193796ebdd55cb69c9f03be0ed412c0ba28de
- :green_heart: Build #85822 succeeded b7d6ed3ceb82b72f9cd87242f64d4174485ecd9f
- :yellow_heart: Build #85647 was flaky 29bb6a327204a4aa2d29e63f00a3a6adc8e12f01
- :yellow_heart: Build #85515 was flaky 76122dba805840863a5595b223e5cc0a94a3571a
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream