kibana
kibana copied to clipboard
elastic
[Cloud Posture] Rename and modify dataYml to runtimeCfg
Summary
This PR modify the following:
- CSP plugin to become benchmark agnostic.
- Rename dataYaml to runtimeCfg
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
- [ ] This was checked for cross-browser compatibility
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---|---|---|---|
| Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| See more potential risk examples |
For maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately
@kfirpeled Make sure you test with the matching integration version https://github.com/elastic/integrations/pull/3968
Missed that, thanks @eyalkraft I've also noticed after the merge from upstream that the section of filling in AWS credentials is missing @uri-weisman, did you notice that? It is also missing in edit mode
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)
Missed that, thanks @eyalkraft I've also noticed after the merge from upstream that the section of filling in AWS credentials is missing @uri-weisman, did you notice that? It is also missing in edit mode
Had some merge conflicts but now we're good to go.
Rejecting fast, after merge I experienced the following:
- No default value for kubernetes integration - being able to save it without it caused an integration with 0 rules
- Cannot select EKS
PFA the following recording showing these issues: https://user-images.githubusercontent.com/61654899/184533043-40e29e29-e20f-44ee-b257-b68245e0c773.mov
:green_heart: Build Succeeded
- Buildkite Build
- Commit: fe745dead531b256116ccbae8761c04e69bfc4ce
Metrics [docs]
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
cloudSecurityPosture |
212.4KB | 212.4KB | -42.0B |
Page load bundle
Size of the bundles that are downloaded on every page load. Target size is below 100kb
| id | before | after | diff |
|---|---|---|---|
cloudSecurityPosture |
10.0KB | 10.0KB | +4.0B |
History
- :broken_heart: Build #64991 failed 3b586c4f33cb9c87da89bb8e2845be141d202375
- :broken_heart: Build #64990 failed 787096c6b9f13c4bda3b3c163fce94fe2020e281
- :broken_heart: Build #64988 failed 99b311336aa0957d6123dbddea2aa9c25e953da4
- :green_heart: Build #64144 succeeded 95065de584d6e01f3d85b130aac9589384ff2394
- :broken_heart: Build #64137 failed 6a8d0d01bb72e8e4eba6b77013d52e5dc0574feb
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
