kibana
kibana copied to clipboard
elastic
[Synthetics] Add monitor detail flyout
Summary
Note to reviewers: you can test this PR using the cloud deployment we've made.
Credentials are available here.
Resolves #135150.
Introduces monitor detail flyout for Synthetics UI.
Additional notes
There are a few modifications to functionality that was merged previously. I've extracted the toast notifications for the enable/disable hook to an effect that is tied to the redux action responsible for the actual API request. There were numerous cases where the current solution is vulnerable to multiple notification calls because they're inferring when the send a toast based on local app state.
This way, the notification is tied to the resolution of the request, and it handles errors as well.
Testing
Some high-level things to test in addition to regular review scrutiny:
- Viewing and opening the flyout via the actions popover
- Opening popover by clicking metric items
- Enable/disable monitor(s) via the flyout and actions popover
@dominiqueclarke I think I have addressed all the feedback from your last review except for the issue with Project Monitors. If you'd like, we can add this to the list of things we plan to iteratively fix. I'm going to make a follow-up issue detailing items we are blocked on or delaying for various reasons.
:yellow_heart: Build succeeded, but was flaky
- Buildkite Build
- Commit: 4786c76895aad3e3f3fe330a7b03329af5d6e391
- Cloud Deployment
Failed CI Steps
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
synthetics |
1010 | 1013 | +3 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
synthetics |
1.1MB | 1.1MB | +12.2KB |
Unknown metric groups
ESLint disabled in files
| id | before | after | diff |
|---|---|---|---|
osquery |
1 | 2 | +1 |
ESLint disabled line counts
| id | before | after | diff |
|---|---|---|---|
enterpriseSearch |
19 | 21 | +2 |
fleet |
58 | 64 | +6 |
osquery |
108 | 113 | +5 |
securitySolution |
440 | 446 | +6 |
| total | +19 |
Total ESLint disabled count
| id | before | after | diff |
|---|---|---|---|
enterpriseSearch |
20 | 22 | +2 |
fleet |
66 | 72 | +6 |
osquery |
109 | 115 | +6 |
securitySolution |
517 | 523 | +6 |
| total | +20 |
History
- :broken_heart: Build #85098 failed b74ffa74c7dedca0c878a8ddd52b66e1a549f0b6
- :broken_heart: Build #85097 failed b74ffa74c7dedca0c878a8ddd52b66e1a549f0b6
- :green_heart: Build #84123 succeeded 287403c1c942074c977f7d5886dac6c8ad6526ca
- :broken_heart: Build #83342 failed 686e9678871d7e89588cee77532921d38e7f5c5f
- :broken_heart: Build #83258 failed 6079738d5cbfde091b2fbacf31fb55b716485244
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @justinkambic
:green_heart: Build Succeeded
- Buildkite Build
- Commit: 7ea5393a448cf991445d7204b097d467de653827
- Cloud Deployment
Metrics [docs]
Module Count
Fewer modules leads to a faster build time
| id | before | after | diff |
|---|---|---|---|
synthetics |
1015 | 1018 | +3 |
Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
| id | before | after | diff |
|---|---|---|---|
synthetics |
1.1MB | 1.1MB | +12.2KB |
Unknown metric groups
ESLint disabled in files
| id | before | after | diff |
|---|---|---|---|
osquery |
1 | 2 | +1 |
ESLint disabled line counts
| id | before | after | diff |
|---|---|---|---|
enterpriseSearch |
19 | 21 | +2 |
fleet |
58 | 64 | +6 |
osquery |
108 | 113 | +5 |
securitySolution |
440 | 446 | +6 |
| total | +19 |
Total ESLint disabled count
| id | before | after | diff |
|---|---|---|---|
enterpriseSearch |
20 | 22 | +2 |
fleet |
66 | 72 | +6 |
osquery |
109 | 115 | +6 |
securitySolution |
517 | 523 | +6 |
| total | +20 |
History
- :yellow_heart: Build #85546 was flaky 4786c76895aad3e3f3fe330a7b03329af5d6e391
- :broken_heart: Build #85098 failed b74ffa74c7dedca0c878a8ddd52b66e1a549f0b6
- :broken_heart: Build #85097 failed b74ffa74c7dedca0c878a8ddd52b66e1a549f0b6
- :green_heart: Build #84123 succeeded 287403c1c942074c977f7d5886dac6c8ad6526ca
- :broken_heart: Build #83342 failed 686e9678871d7e89588cee77532921d38e7f5c5f
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @justinkambic