kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/rule_details_page·ts - ObservabilityApp Observability Rule Details page Page components maps correctly the rule type with the human readable rule type

Open kibanamachine opened this issue 3 years ago • 7 comments

A test failed on a tracked branch

Error: expected 'logs.alert.document.count' to equal 'Log threshold'
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (node_modules/@kbn/expect/expect.js:69:22)
    at Context.<anonymous> (x-pack/test/observability_functional/apps/observability/pages/rule_details_page.ts:136:29)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - main

kibanamachine avatar Jul 08 '22 11:07 kibanamachine

Pinging @elastic/uptime (Team:uptime)

elasticmachine avatar Jul 08 '22 16:07 elasticmachine

Pinging @elastic/unified-observability (Team:Observability)

elasticmachine avatar Jul 08 '22 16:07 elasticmachine

New failure: CI Build - 8.3

kibanamachine avatar Jul 13 '22 17:07 kibanamachine

This has failed 15 times in the last week, all in PRs which is why this hasn't triggered any comments

image

Skipped main/8.5: https://github.com/elastic/kibana/commit/ea2098fea07ea67380b9cfc995503576ff58bf50 8.4: https://github.com/elastic/kibana/commit/e902476ddef4b392f1796718c7efdab92c40503b 8.3: https://github.com/elastic/kibana/commit/7e72f3d568ae16807f7dd6e7273e863aeafcf645

spalger avatar Jul 27 '22 16:07 spalger

Pinging @elastic/actionable-observability (Team: Actionable Observability)

elasticmachine avatar Aug 02 '22 11:08 elasticmachine

Looking at the failed test, it looks like a legitimate failure. Oddly enough when run locally, it fails in a completely different way. Digging into this now...

simianhacker avatar Aug 08 '22 20:08 simianhacker

It looks like this test needs to take into account that the page is fully loaded before it looks at the ruleSummaryRuleType test subject. There is a hook inside that component that loads all the rule types and their names. There is a possibility that when that's not completely loaded it will display the rule type ID instead of the actual name. But as soon as that's completely loaded, it should resolve back to the human readable name. We probably need to add a loading spinner to that component and then fix the test to wait till the spinner is removed.

simianhacker avatar Aug 08 '22 22:08 simianhacker