kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Failing test: Jest Integration Tests.src/core/server/elasticsearch/integration_tests - fake elasticsearch should return unknown product when it cannot perform the Product check (503 response)

Open kibanamachine opened this issue 3 years ago • 5 comments

A test failed on a tracked branch

Error: expect(received).toBe(expected) // Object.is equality

Expected: "critical"
Received: "unavailable"
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/src/core/server/elasticsearch/integration_tests/client.test.ts:94:44)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-bc5f5d6543db3d55/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:472:34)

First failure: CI Build - main

kibanamachine avatar Apr 07 '22 14:04 kibanamachine

Pinging @elastic/kibana-core (Team:Core)

elasticmachine avatar Apr 07 '22 14:04 elasticmachine

New failure: CI Build - 8.2

kibanamachine avatar Apr 11 '22 23:04 kibanamachine

Failed 5 PRs this week

image

8.3/main: https://github.com/elastic/kibana/commit/fc7d3850bd21ddb23cab50f41f16822147c61be7 8.2: https://github.com/elastic/kibana/commit/72501b9eec4f5011d9e9783c8bcec70b0bebb732

spalger avatar Apr 15 '22 16:04 spalger

This unavailable status is coming from here:

https://github.com/elastic/kibana/blob/5edf7e267aecb5b48c90ca3d616c272d194153b5/src/core/server/elasticsearch/status.ts#L20-L27

Which means that for some reason, esNodesCompatibility$ did not emit yet, or, more likely, the emission was not propagated to the observable used by the /api/status endpoint when we're reaching this line:

https://github.com/elastic/kibana/blob/fc7d3850bd21ddb23cab50f41f16822147c61be7/src/core/server/elasticsearch/integration_tests/client.test.ts#L94

Looking at the code, we have some debounces in the observable chain, e.g this one:

https://github.com/elastic/kibana/blob/9d5aca591b08f93729b702bcd47311cb33e227a8/src/core/server/status/status_service.ts#L72-L74

and we're using a combineLatest operator for the /status/api route:

https://github.com/elastic/kibana/blob/9d5aca591b08f93729b702bcd47311cb33e227a8/src/core/server/status/routes/status.ts#L64-L66

Given we're using a local 'fake' service and the overall quick time it takes for core to complete the setup phase, this looks like a simple race issue.

pgayvallet avatar Apr 21 '22 08:04 pgayvallet

@gsoldevila, do you think that we can backport https://github.com/elastic/kibana/pull/148616 to 7.17? It looks like it's failing in that branch.

afharo avatar Aug 08 '24 15:08 afharo

In progress https://github.com/elastic/kibana/pull/190158

gsoldevila avatar Aug 08 '24 15:08 gsoldevila

Backport merged (thanks @gsoldevila)! Closing this issue.

afharo avatar Aug 08 '24 19:08 afharo