eui icon indicating copy to clipboard operation
eui copied to clipboard

[DRAFT] `useEuiContainerQuery`

Open acstll opened this issue 4 weeks ago • 3 comments

Summary

Closes #8963

WIP

Why are we making this change?

Screenshots

Impact to users

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • [ ] Checked in both light and dark modes
    • [ ] Checked in both MacOS and Windows high contrast modes
    • [ ] Checked in mobile
    • [ ] Checked in Chrome, Safari, Edge, and Firefox
    • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • [ ] A changelog entry exists and is marked appropriately
    • [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • [ ] If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • [ ] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

acstll avatar Dec 01 '25 17:12 acstll

I refactored the polyfill code into a plain function, added some clean up logic, and it's working nicely… (also left a couple of comments above)

@tkajtoch how would you measure any possible performance impact? (there's a single call to getComputedStyle with no access to props e.g. height, and only calling getPropertyValue which shouldn't cause any trouble) (but I'm not certain)

if this is aligned with what you had in mind originally, I'm glad to wrap it up (add tests, JSDoc, etc.) — let me know what you think 🙂

acstll avatar Dec 04 '25 12:12 acstll

:green_heart: Build Succeeded

History

  • :green_heart: Build #2160 succeeded aa52db34fa106f923fbd480a57e97656e70e3cff
  • :green_heart: Build #2158 succeeded 33d95b0fb2c1b9e76121c762970442902144d3cf
  • :broken_heart: Build #2131 failed 7587bee25863f43651d5f5679d4fe1d4111d4f12
  • :green_heart: Build #2123 succeeded 4e5e43bb7a461a64850b808520808aab052ebda0

cc @acstll

elasticmachine avatar Dec 04 '25 13:12 elasticmachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #5387 succeeded aa52db34fa106f923fbd480a57e97656e70e3cff
  • :broken_heart: Build #5362 failed 7587bee25863f43651d5f5679d4fe1d4111d4f12
  • :green_heart: Build #5355 succeeded 4e5e43bb7a461a64850b808520808aab052ebda0

cc @acstll

elasticmachine avatar Dec 04 '25 13:12 elasticmachine