feat(eui): remove xl size from EuiTabs
Summary
[!IMPORTANT] This is a breaking change.
Closes https://github.com/elastic/eui/issues/8302
On this PR, I:
Kibana impact
There are no usages in Kibana of EuiTabs with xl size (search) or EuiPageHeader / KibanaPageTemplate.Header with tabs but no pageTitle.
Cloud UI impact
There are no usages in Cloud UI of EuiTabs with xl size (search) or EuiPageHeader with tabs but no pageTitle.
QA
Specific checklist
- [x] EUI builds with no errors
- [x] Unit tests pass
- [ ] The Kibana and Cloud UI affected usages list is correct
General checklist
- Browser QA
- [ ] ~Checked in both light and dark modes~
- [ ] ~Checked in both MacOS and Windows high contrast modes~
- (emulate forced colors if you do not have access to a Windows machine.)
- [ ] ~Checked in mobile~
- [ ] ~Checked in Chrome, Safari, Edge, and Firefox~
- [ ] ~Checked for accessibility including keyboard-only and screenreader modes~
- Docs site QA
- [ ] ~Added documentation~
- [ ] ~Props have proper autodocs (using
@defaultif default values are missing) and playground toggles~ - [ ] ~Checked Code Sandbox works for any docs examples~
- Code quality checklist
- [x] Added or updated jest ~and cypress tests~
- [ ] ~Updated visual regression tests~
- Release checklist
- [x] A changelog entry exists and is marked appropriately.
- [x] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
- Designer checklist
- [x] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)
Would page_header_content.tsx also need to change?
https://github.com/elastic/eui/blob/803bdb959de54eff4aa96789a3644885370bd39d/packages/eui/src/components/page/page_header/page_header_content.tsx#L275
@ryankeairns yes, we'd need to change page_header_content.tsx which would affect EuiPageHeader and KibanaPageTemplate.Header.
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
- If this PR contains prop/API changes:
- [x] Search through Kibana for
<EuiComponentusages (example search) - [x] In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
- [x] Search through Kibana for
- If this PR contains CSS changes:
- [ ] Search through Kibana for the changed EUI selectors, e.g.
.euiComponent(example search) - [ ] In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
- [ ] Search through Kibana for the changed EUI selectors, e.g.
- 🔍 Tip: When searching through Kibana, consider excluding
**/target, **/*.snap, **/*.storyshotfiles to reduce noise and only look at source code usages - ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
- Using a pre-release release candidate to test Kibana CI ahead of time
- Using
kibana-a-la-cartefor manual QA, and to give other Kibana teams a staging server to quickly test against
:green_heart: Build Succeeded
- Buildkite Build
- Commit: a042b8c87131b1fa9f89aa334a83801b709f736a
- Documentation website
History
- :broken_heart: Build #422 failed e6bd07ca86f0e04bb4e688631c72ce4d3242925e
cc @weronikaolejniczak
:green_heart: Build Succeeded
- Buildkite Build
- Commit: a042b8c87131b1fa9f89aa334a83801b709f736a
History
- :broken_heart: Build #4114 failed e6bd07ca86f0e04bb4e688631c72ce4d3242925e
cc @weronikaolejniczak