eui icon indicating copy to clipboard operation
eui copied to clipboard

feat(eui): remove xl size from EuiTabs

Open weronikaolejniczak opened this issue 6 months ago • 5 comments

Summary

[!IMPORTANT] This is a breaking change.

Closes https://github.com/elastic/eui/issues/8302

On this PR, I:

Kibana impact

There are no usages in Kibana of EuiTabs with xl size (search) or EuiPageHeader / KibanaPageTemplate.Header with tabs but no pageTitle.

Cloud UI impact

There are no usages in Cloud UI of EuiTabs with xl size (search) or EuiPageHeader with tabs but no pageTitle.

QA

Specific checklist

  • [x] EUI builds with no errors
  • [x] Unit tests pass
  • [ ] The Kibana and Cloud UI affected usages list is correct

General checklist

  • Browser QA
    • [ ] ~Checked in both light and dark modes~
    • [ ] ~Checked in both MacOS and Windows high contrast modes~
    • [ ] ~Checked in mobile~
    • [ ] ~Checked in Chrome, Safari, Edge, and Firefox~
    • [ ] ~Checked for accessibility including keyboard-only and screenreader modes~
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • [x] A changelog entry exists and is marked appropriately.
    • [x] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • [x] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

weronikaolejniczak avatar Jun 06 '25 16:06 weronikaolejniczak

Would page_header_content.tsx also need to change?

https://github.com/elastic/eui/blob/803bdb959de54eff4aa96789a3644885370bd39d/packages/eui/src/components/page/page_header/page_header_content.tsx#L275

ryankeairns avatar Jun 06 '25 18:06 ryankeairns

@ryankeairns yes, we'd need to change page_header_content.tsx which would affect EuiPageHeader and KibanaPageTemplate.Header.

weronikaolejniczak avatar Jun 06 '25 18:06 weronikaolejniczak

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • [x] Search through Kibana for <EuiComponent usages (example search)
    • [x] In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • [ ] Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • [ ] In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

github-actions[bot] avatar Jun 10 '25 08:06 github-actions[bot]

:green_heart: Build Succeeded

History

  • :broken_heart: Build #422 failed e6bd07ca86f0e04bb4e688631c72ce4d3242925e

cc @weronikaolejniczak

elasticmachine avatar Jun 10 '25 08:06 elasticmachine

:green_heart: Build Succeeded

History

  • :broken_heart: Build #4114 failed e6bd07ca86f0e04bb4e688631c72ce4d3242925e

cc @weronikaolejniczak

elasticmachine avatar Jun 10 '25 09:06 elasticmachine