eui icon indicating copy to clipboard operation
eui copied to clipboard

Add clear functionality to EuiDatePickerRange

Open ChrisJamesC opened this issue 8 months ago • 6 comments
trafficstars

Summary

Propagate the clear prop from EuiFormControlLayoutDelimited to EuiDatePickerRange so we can clear a date range in a consistent way as for other form elements.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • [ ] Checked in both light and dark modes
    • [ ] Checked in mobile
    • [ ] Checked in Chrome, Safari, Edge, and Firefox
    • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • [ ] A changelog entry exists and is marked appropriately.
    • [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • [ ] If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

ChrisJamesC avatar Mar 11 '25 22:03 ChrisJamesC

💚 CLA has been signed

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

github-actions[bot] avatar Mar 11 '25 22:03 github-actions[bot]

Hey @ChrisJamesC 👋🏻 what's the status of this PR? Do you need any guidance? 😄 Let me know and thank you for contributing!

weronikaolejniczak avatar Apr 23 '25 12:04 weronikaolejniczak

Hi @weronikaolejniczak, thanks for reaching out. Given the limited scope of the change I'm not sure how much of the checklist I must go through.

ChrisJamesC avatar Apr 24 '25 13:04 ChrisJamesC

@ChrisJamesC here are some things we'd need to do:

  • [ ] add a changelog (you can refer to our wiki)
  • [ ] add a unit test for clearing EuiDatePickerRange
  • [ ] verify the prop is available as a control in Storybook

You can strikethrough any other checklist element.

If this PR is coming out of a feature request, let's mention it in the description (preferably with closing keywords).

Let me know once you've done the changes and I'll test. And if you need any help, don't hesitate to reach out 😄

weronikaolejniczak avatar Apr 25 '25 08:04 weronikaolejniczak

Hey @ChrisJamesC 👋🏻 let me know if you need any guidance on moving this PR forward!

weronikaolejniczak avatar Jun 03 '25 11:06 weronikaolejniczak

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Nov 06 '25 16:11 github-actions[bot]

❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error.

github-actions[bot] avatar Nov 14 '25 00:11 github-actions[bot]