eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiTabbedContent] Fixed issue of TypeError #7350

Open shyamal2411 opened this issue 1 year ago • 6 comments

Summary

This PR fixes Issue #7350. Refactored the EuiTabbedContent component to ensure that the selected tab remains consistent with the provided initialSelectedTab or selectedTab props. Additionally, addressed the issue where the getDerivedStateFromProps method could return undefined, ensuring it always returns a valid state object or null.

General checklist

  • Browser QA
    • [x] Checked in both light and dark modes
    • [x] Checked in Chrome, Safari, Edge, and Firefox
  • Docs site QA
    • [x] Props have proper autodocs (using @default if default values are missing) and playground toggles
    • [x] Checked Code Sandbox works for any docs examples
  • Code quality checklist

shyamal2411 avatar Apr 25 '24 18:04 shyamal2411

💚 CLA has been signed

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

github-actions[bot] avatar Apr 25 '24 18:04 github-actions[bot]

buildkite test this

cee-chen avatar Apr 25 '24 18:04 cee-chen

@shyamal2411 Thank you for the PR! 🎉 As a heads up, you'll need to sign the contributor agreement (link) with the email address associated with your git commits! You can git log to check what that email address is.

cee-chen avatar Apr 25 '24 18:04 cee-chen

buildkite test this

cee-chen avatar Apr 29 '24 21:04 cee-chen

Preview staging links for this PR:

  • Docs site: https://eui.elastic.co/pr_7713/
  • Storybook: https://eui.elastic.co/pr_7713/storybook

kibanamachine avatar Apr 29 '24 21:04 kibanamachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #1827 succeeded a61313e02b20fd4c9d7a7337f2da64de928e8edf

elasticmachine avatar Apr 29 '24 21:04 elasticmachine