eui icon indicating copy to clipboard operation
eui copied to clipboard

[React 18] EuiOverlayMask component skips non-string property test case

Open tkajtoch opened this issue 2 years ago • 3 comments

Current behavior

<EuiOverlayMask> test suite is skipping the throws if a non-string property value is passed test case when testing on React 18 runtime due to an unexpected error happening somewhere in Jest or RTL.

Expected behavior

<EuiOverlayMask> should test for non-string property throw.

tkajtoch avatar Jul 26 '23 16:07 tkajtoch

Mentioning Tomasz's comment for completeness:

I tried wrapping <EuiOverlayMask aria-hidden={true} /> in class component with componentDidCatch, rendering it differently, moving the throw statement outside useEffect and none seemed to help.

cee-chen avatar Jul 26 '23 17:07 cee-chen

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Jan 28 '24 16:01 github-actions[bot]

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Jul 28 '24 00:07 github-actions[bot]