eui icon indicating copy to clipboard operation
eui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[EuiSuggest] Accept `isPreFiltered` prop

Open omar-zahid opened this issue 2 years ago • 6 comments

Summary

EuiSuggest props currently does not accept isPreFiltered prop which does exist in the Selectable component.

From the documents, isPreFiltered:

Control whether or not options get filtered internally or if consumer will filter Default: false

Recommending to allow EuiSuggest component to accept isPreFiltered prop to introduce the same functionality above to EuiSuggest component

Checklist

  • [ ] Checked in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • [ ] Added or updated jest and cypress tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • [ ] Updated the Figma library counterpart
  • [ ] A changelog entry exists and is marked appropriately

omar-zahid avatar May 25 '22 20:05 omar-zahid

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

kibanamachine avatar May 25 '22 20:05 kibanamachine

💚 CLA has been signed

cla-checker-service[bot] avatar May 25 '22 20:05 cla-checker-service[bot]

Hey @omar-zahid,

When you're ready for review, please update the summary and check or remove each checklist item. Also, sign the CLA if you haven't already done so.

Thanks!

thompsongl avatar May 26 '22 14:05 thompsongl

Thanks @thompsongl Sure. I have also signed the CLA however its not being reflected as signed here, not sure why.

omar-zahid avatar May 31 '22 13:05 omar-zahid

Thanks! Could you also add a changelog entry?

jenkins test this

thompsongl avatar May 31 '22 15:05 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/

kibanamachine avatar May 31 '22 15:05 kibanamachine

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Aug 29 '22 16:08 github-actions[bot]

Hey @omar-zahid Do you still want to see this PR merged? If you don't have time to finish it, we can take over from here.

Just let us know! Thanks again for helping out!

thompsongl avatar Sep 01 '22 15:09 thompsongl

Hi @thompsongl Sorry been away for a while. It would be helpful if you can take it from here. I would love to have this feature merged in. Apologies again for the delay.

omar-zahid avatar Sep 06 '22 11:09 omar-zahid

Not a problem! We will get the branch updated and this PR merged.

thompsongl avatar Sep 06 '22 15:09 thompsongl

jenkins test this

thompsongl avatar Sep 06 '22 15:09 thompsongl

Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/

kibanamachine avatar Sep 06 '22 15:09 kibanamachine