eui icon indicating copy to clipboard operation
eui copied to clipboard

Sort fields panel position misaligned in full screen view

Open bhavyarm opened this issue 3 years ago • 5 comments

Kibana version: 8.3.0 snapshot

Elasticsearch version: 8.3.0 snapshot

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you click open sort field ->clear sorting -> pick fields to sort by -> click on full screen , Kibana displays sort fields panel in the middle of screen in discover full screen.

Screen Shot 2022-05-10 at 5 48 37 PM

Plus clicking back on this screen navigates the user away to homescreen instead of discover. ESC works to exit the user from full screen mode.

https://user-images.githubusercontent.com/7074629/167727949-c683ff77-fbc1-4abc-af55-4b57c5cb39e3.mp4

bhavyarm avatar May 10 '22 21:05 bhavyarm

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine avatar May 10 '22 21:05 elasticmachine

Transferring the issue because it's also reproducible in the EUI docs, so it's not Kibana related

kertal avatar May 11 '22 08:05 kertal

Plus clicking back on this screen navigates the user away to homescreen instead of discover. ESC works to exit the user from full screen mode.

There's an issue for that https://github.com/elastic/eui/issues/4393

kertal avatar May 11 '22 08:05 kertal

Looks like this behavior is essentially being caused by the nested EuiPopover behavior. Only one outside click on close event is being triggered.

@cchaos, @miukimiu, can we consider another UI/UX alternative to picking a field to sort by? Can we use an accordion instead for instance, or an EuiContextMenuPanel?

cee-chen avatar May 11 '22 16:05 cee-chen

Honestly, I wonder if there's a good way to combine both column visibility and sort functionality. I don't know if it's enough just to have an initially de-selected button group to visualize sorting. But here's a VERY quick mock that just combines them both without any other thought. The only problem here would be that sort order would now be dependent on column order (but maybe that's not so bad).

image

cchaos avatar May 11 '22 17:05 cchaos

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

github-actions[bot] avatar Sep 22 '25 00:09 github-actions[bot]