elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Standardized exception messages

Open ZERDICORP opened this issue 3 years ago • 4 comments

Standardized the text of exception messages for parameters of methods of the SearchSourceBuilder & CountRequest classes. Messages are reduced to the general structure:

[param] <message>, got <value>

ZERDICORP avatar Jul 11 '22 11:07 ZERDICORP

Pinging @elastic/es-search (Team:Search)

elasticmachine avatar Jul 12 '22 16:07 elasticmachine

Pinging @elastic/clients-team (Team:Clients)

elasticmachine avatar Jul 18 '22 18:07 elasticmachine

hi @ZERDICORP thanks for your contribution. Is your PR fixing an existing issue? If so I don't see it linked in the PR description.

javanna avatar Aug 09 '22 15:08 javanna

hi @javanna, no, this PR is not related to any issue

ZERDICORP avatar Aug 09 '22 19:08 ZERDICORP

@elasticmachine ok to test

javanna avatar Aug 11 '22 10:08 javanna

@elasticmachine update branch

javanna avatar Aug 11 '22 10:08 javanna

@ZERDICORP I see how you came up with this improvement. I will try to get it merged, though for the next time I'd suggest that you take one of the existing issues marked help wanted or good first issue, so that we make sure that your energy (as well as ours) is spent on tasks that we would like to see prioritized.

I ran the build and I see some spotless violations. Could you please run ./gradlew spotlessApply ?

javanna avatar Aug 11 '22 10:08 javanna

It looks like there are also some test errors, could you please look at those and address them? Thanks!

javanna avatar Aug 11 '22 10:08 javanna

Closing for lack of feedback. Feel free to reopen once you are ready to pick this back up.

javanna avatar Oct 14 '22 12:10 javanna