elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Implement DATE_FORMAT function

Open didendron opened this issue 2 years ago • 4 comments

Implement DATE_FORMAT according to the MySQL spec: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format Tested against the actual output from MySQL using randomized inputs Documentation Integration tests

Relates to https://github.com/elastic/elasticsearch/issues/55065

didendron avatar Jul 08 '22 15:07 didendron

💚 CLA has been signed

@cla-bot check

didendron avatar Jul 10 '22 10:07 didendron

Pinging @elastic/es-ql (Team:QL)

elasticmachine avatar Jul 12 '22 16:07 elasticmachine

@elasticmachine test this please

luigidellaquila avatar Aug 09 '22 08:08 luigidellaquila

Hi @didendron

Thank you very much for the quick feedback on my comments. I ran the tests locally and I see ConsistentFunctionArgHandlingIT is still failing. I think adding the function name to ConsistentFunctionArgHandlingIT-non-tested-functions.txt should be enough to fix it.

After that, could you please run the tests again and see if something else is missing?

Thanks

Luigi

luigidellaquila avatar Aug 12 '22 08:08 luigidellaquila

@elasticmachine test this please

luigidellaquila avatar Aug 23 '22 14:08 luigidellaquila

Hi @didendron

Thank you very much, this looks good for me now. Please, just align the PR with main branch (ie. merge main branch) so that I can run some final tests.

Thanks!

luigidellaquila avatar Aug 24 '22 11:08 luigidellaquila

@elasticmachine test this please

luigidellaquila avatar Aug 25 '22 09:08 luigidellaquila

Hi @didendron

Thank you very much for following up on this, I think we are almost there. If you could just address last comment from @astefan, I'd go on and merge

Thanks

Luigi

luigidellaquila avatar Sep 07 '22 14:09 luigidellaquila

@Luegg, @astefan, and @luigidellaquila in particular thank you for your help and support.

didendron avatar Sep 08 '22 17:09 didendron

Hi @didendron, Please, align the PR with main branch (ie. merge main branch) so that we can run the tests one more time with your new updates. Thanks.

astefan avatar Sep 08 '22 18:09 astefan

@elasticmachine test this please

astefan avatar Sep 09 '22 18:09 astefan

@elasticmachine run elasticsearch-ci/docs

astefan avatar Sep 09 '22 18:09 astefan

Thank you very much @didendron, I'm merging the PR

luigidellaquila avatar Sep 12 '22 07:09 luigidellaquila