elasticsearch
elasticsearch copied to clipboard
Implement DATE_FORMAT function
Implement DATE_FORMAT according to the MySQL spec: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format Tested against the actual output from MySQL using randomized inputs Documentation Integration tests
Relates to https://github.com/elastic/elasticsearch/issues/55065
💚 CLA has been signed
@cla-bot check
Pinging @elastic/es-ql (Team:QL)
@elasticmachine test this please
Hi @didendron
Thank you very much for the quick feedback on my comments.
I ran the tests locally and I see ConsistentFunctionArgHandlingIT
is still failing. I think adding the function name to ConsistentFunctionArgHandlingIT-non-tested-functions.txt
should be enough to fix it.
After that, could you please run the tests again and see if something else is missing?
Thanks
Luigi
@elasticmachine test this please
Hi @didendron
Thank you very much, this looks good for me now.
Please, just align the PR with main
branch (ie. merge main branch) so that I can run some final tests.
Thanks!
@elasticmachine test this please
Hi @didendron
Thank you very much for following up on this, I think we are almost there. If you could just address last comment from @astefan, I'd go on and merge
Thanks
Luigi
@Luegg, @astefan, and @luigidellaquila in particular thank you for your help and support.
Hi @didendron, Please, align the PR with main branch (ie. merge main branch) so that we can run the tests one more time with your new updates. Thanks.
@elasticmachine test this please
@elasticmachine run elasticsearch-ci/docs
Thank you very much @didendron, I'm merging the PR