elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Capture deprecation warnings in batched master tasks

Open DaveCTurner opened this issue 2 years ago • 4 comments

It's possible for a cluster state update task to emit deprecation warnings, but if the task is executed in a batch then these warnings will be exposed to the listener for every item in the batch. With this commit we introduce a mechanism for tasks to capture just the warnings relevant to them, along with assertions that warnings are not inadvertently leaked back to the master service.

Closes #85506

DaveCTurner avatar Mar 31 '22 07:03 DaveCTurner

Pinging @elastic/es-distributed (Team:Distributed)

elasticmachine avatar Mar 31 '22 07:03 elasticmachine

Not ready to merge, this needs testing in MasterServiceTests too, but before I start on that I want to see whether CI finds any other cases that need fixing and/or some more fundamental problems.

DaveCTurner avatar Mar 31 '22 07:03 DaveCTurner

Hi @DaveCTurner, I've created a changelog YAML for you.

elasticsearchmachine avatar May 09 '22 10:05 elasticsearchmachine

The Windows packaging test failure is definitely unrelated and I'm pretty sure the DiscoveryDisruptionIT is too - opened #86974 to track it.

DaveCTurner avatar May 20 '22 14:05 DaveCTurner