elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

SearchServiceTests.testParseSourceValidation fails

Open benwtrent opened this issue 1 year ago • 2 comments

CI Link

https://gradle-enterprise.elastic.co/s/kwj5ep3e5vymm

Repro line

./gradlew ":server:test" --tests "org.elasticsearch.search.SearchServiceTests.testParseSourceValidation" -Dtests.seed=DB172D57BA3537A5 -Dtests.locale=ar-BH -Dtests.timezone=America/Argentina/San_Luis -Druntime.java=22

Does it reproduce?

Yes

Applicable branches

main

Failure history

No response

Failure excerpt

SearchServiceTests > testParseSourceValidation FAILED
    java.lang.AssertionError:
    Expected: a string containing "`search_after` cannot be used in a scroll context."
         but: was "Sort must contain at least one field."
        at __randomizedtesting.SeedInfo.seed([DB172D57BA3537A5:48807AB8AFE2159C]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
        at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2543)
        at org.elasticsearch.search.SearchServiceTests.assertCreateContextValidation(SearchServiceTests.java:3038)
        at org.elasticsearch.search.SearchServiceTests.testParseSourceValidation(SearchServiceTests.java:2947)

benwtrent avatar Oct 30 '24 13:10 benwtrent

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine avatar Oct 30 '24 13:10 elasticsearchmachine

Marking low-risk, the test was muted and then the checking order changed for the request, so now the response is a different message.

It is still an IllegalArgumentException with a different message, so users would receive a 400 back in case this is not a testing issue.

carlosdelest avatar Oct 30 '24 17:10 carlosdelest

Pinging @elastic/es-search-relevance (Team:Search Relevance)

elasticsearchmachine avatar Nov 07 '24 13:11 elasticsearchmachine

Committed #117963

drempapis avatar Dec 05 '24 16:12 drempapis