elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

[CI] EsqlNodeSubclassTests testReplaceChildren {class org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec} failing

Open dnhatn opened this issue 1 year ago • 2 comments

Build scan: https://gradle-enterprise.elastic.co/s/47fbbam76eizg/tests/:x-pack:plugin:esql:test/org.elasticsearch.xpack.esql.tree.EsqlNodeSubclassTests/testReplaceChildren%20%7Bclass%20org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec%7D

Reproduction line:

./gradlew ':x-pack:plugin:esql:test' --tests "org.elasticsearch.xpack.esql.tree.EsqlNodeSubclassTests" -Dtests.method="testReplaceChildren {class org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec}" -Dtests.seed=B0B2191121F9A3FF -Dtests.locale=it-CH -Dtests.timezone=Europe/Berlin -Druntime.java=22

Applicable branches: main

Reproduces locally?: Yes

Failure history: Failure dashboard for org.elasticsearch.xpack.esql.tree.EsqlNodeSubclassTests#testReplaceChildren {class org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec}

Failure excerpt:

java.lang.UnsupportedOperationException: Other JOINs than LEFT not supported

  at __randomizedtesting.SeedInfo.seed([B0B2191121F9A3FF:894DBA5CD8FF8301]:0)
  at org.elasticsearch.xpack.esql.plan.logical.join.Join.computeOutput(Join.java:117)
  at org.elasticsearch.xpack.esql.plan.logical.join.Join.output(Join.java:98)
  at org.elasticsearch.xpack.esql.plan.physical.FragmentExec.output(FragmentExec.java:66)
  at org.elasticsearch.xpack.esql.core.plan.QueryPlan.outputSet(QueryPlan.java:40)
  at org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec.extractSourceAttributesFrom(FieldExtractExec.java:43)
  at org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec.<init>(FieldExtractExec.java:38)
  at org.elasticsearch.xpack.esql.plan.physical.FieldExtractExec.replaceChild(FieldExtractExec.java:58)
  at org.elasticsearch.xpack.esql.plan.physical.UnaryExec.replaceChildren(UnaryExec.java:28)
  at org.elasticsearch.xpack.esql.plan.physical.UnaryExec.replaceChildren(UnaryExec.java:17)
  at org.elasticsearch.xpack.esql.core.tree.NodeSubclassTests.testReplaceChildren(NodeSubclassTests.java:223)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1570)

dnhatn avatar Jun 28 '24 14:06 dnhatn

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine avatar Jun 28 '24 14:06 elasticsearchmachine

I've seen several different tests failing in this class, muting the whole suite while the problems are addressed - see 3bc485cafe6.

DaveCTurner avatar Jun 30 '24 15:06 DaveCTurner

Thanks for the heads-up @DaveCTurner . All of the failures should be fixed by https://github.com/elastic/elasticsearch/pull/110284.

alex-spies avatar Jul 01 '24 08:07 alex-spies

There is one more, unrelated to the fix @alex-spies mentioned: https://github.com/elastic/elasticsearch/issues/110310

astefan avatar Jul 01 '24 08:07 astefan

Ah, that's correct. I'll keep the mute in place just for the tests for toPartial (seems to fail reliably).

alex-spies avatar Jul 01 '24 09:07 alex-spies