elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

[ES|QL] validate mv_sort order

Open fang-xing-esql opened this issue 1 year ago • 3 comments

Resolves #109910

mv_sort validates ASC and DESC as order.

fang-xing-esql avatar Jun 21 '24 05:06 fang-xing-esql

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine avatar Jun 21 '24 05:06 elasticsearchmachine

Hi @fang-xing-esql, I've created a changelog YAML for you.

elasticsearchmachine avatar Jun 21 '24 05:06 elasticsearchmachine

@elasticmachine update branch

astefan avatar Jun 21 '24 09:06 astefan

Pinging @elastic/kibana-esql (ES|QL-ui)

elasticsearchmachine avatar Jul 02 '24 22:07 elasticsearchmachine

Do we need to do something about it in the UI? It is not very obvious from the PR description

stratoula avatar Jul 03 '24 05:07 stratoula

Do we need to do something about it in the UI? It is not very obvious from the PR description

@stratoula This is indirectly linked to this issue https://github.com/elastic/kibana/issues/187311, we'd like to have mv_sort error out when an invalid sort order is provided.

fang-xing-esql avatar Jul 03 '24 13:07 fang-xing-esql